Pipe all composer data through the Vuex store #6186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
reviewed
Apr 6, 2022
JuliaKirschenheuter
approved these changes
Apr 6, 2022
ChristophWurst
commented
Apr 6, 2022
src/components/NewMessageModal.vue
Outdated
| } | ||
| await this.$store.dispatch('outbox/updateMessage', { message: dataForServer, id: this.composerData.id }) | ||
| } else { | ||
| if (data.draftId === undefined && this.draft) { |
There was a problem hiding this comment.
Found it. This is yet another copy-paste error introduced with 35d5d78. this.draft was blindly copied from NewMessageDetail where we actually do handle drafts.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
refactor/composer-outbox-vue
branch
from
933f5f5
to
50524c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6181. This unifies the data handling of the composer to work for both IMAP and local (outbox) messages.
The logic of fetching an original message for the Edit as new message is now handled centrally by the store.
What I've tested