-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outbox backend implementation #6031
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
49470b9
Add outbox backend implementation
miaulalala c9d3437
Only delete drafts that exist
ChristophWurst 12d31f8
Proceed with deletion if object is missing on server
ChristophWurst 1e906b3
Fix outbox message deletion after send
ChristophWurst c90c788
Normalize outbox messages
ChristophWurst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
<?php | ||
|
||
declare(strict_types=1); | ||
|
||
/** | ||
* Mail App | ||
* | ||
* @copyright 2022 Anna Larch <anna.larch@gmx.net> | ||
* | ||
* @author Anna Larch <anna.larch@gmx.net> | ||
* | ||
* This library is free software; you can redistribute it and/or | ||
* modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE | ||
* License as published by the Free Software Foundation; either | ||
* version 3 of the License, or any later version. | ||
* | ||
* This library is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU AFFERO GENERAL PUBLIC LICENSE for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public | ||
* License along with this library. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
namespace OCA\Mail\Contracts; | ||
|
||
use OCA\Mail\Account; | ||
use OCA\Mail\Db\LocalMessage; | ||
use OCA\Mail\Db\Recipient; | ||
use OCA\Mail\Exception\ServiceException; | ||
|
||
interface ILocalMailboxService { | ||
|
||
/** | ||
* @param string $userId | ||
* @return mixed | ||
*/ | ||
public function getMessages(string $userId): array; | ||
|
||
/** | ||
* @param int $id | ||
* | ||
* @return LocalMessage | ||
* | ||
* @throws ServiceException | ||
*/ | ||
public function getMessage(int $id, string $userId): LocalMessage; | ||
|
||
/** | ||
* @param Account $account | ||
* @param LocalMessage $message | ||
* @param Recipient[] $to | ||
* @param Recipient[] $cc | ||
* @param Recipient[] $bcc | ||
* @param array $attachments | ||
* @return LocalMessage | ||
*/ | ||
public function saveMessage(Account $account, LocalMessage $message, array $to, array $cc, array $bcc, array $attachments = []): LocalMessage; | ||
|
||
/** | ||
* @param LocalMessage $message | ||
* @param Recipient[] $to | ||
* @param Recipient[] $cc | ||
* @param Recipient[] $bcc | ||
* @param array $attachments | ||
* @return LocalMessage | ||
*/ | ||
public function updateMessage(Account $account, LocalMessage $message, array $to, array $cc, array $bcc, array $attachments = []): LocalMessage; | ||
|
||
/** | ||
* @param LocalMessage $message | ||
* @param string $userId | ||
*/ | ||
public function deleteMessage(string $userId, LocalMessage $message): void; | ||
|
||
/** | ||
* @param LocalMessage $message | ||
* @param Account $account | ||
* @return void | ||
*/ | ||
public function sendMessage(LocalMessage $message, Account $account): void; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what the old data structure and identification allowed was to receive a message with account A, reply with account B and still get the flag updates on account A. This will break now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised as #6189