Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to material icons #38

Closed
7 tasks done
ChristophWurst opened this issue May 17, 2022 · 8 comments
Closed
7 tasks done

Migrate to material icons #38

ChristophWurst opened this issue May 17, 2022 · 8 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish overview Overview of other issues

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented May 17, 2022

Describe the task

Nextcloud 25 has a hard breaking change and we need to change our icons for it nextcloud/server#32060

Affected components

To do

@ChristophWurst
Copy link
Member Author

How far are we with this migration @GretaD?

@GretaD
Copy link
Contributor

GretaD commented Jun 27, 2022

How far are we with this migration @GretaD?

99% for mail, there are only 2 open PRs, i did a general test last week and i think thats all we have to migrate here(one pr is blocked)
On calendar i think its all done, but i havent test it yet like i did with mail to see if i missed smth.
Contacts, i havent started yet.

If you need an ETA, i can finish all this week (but the blocked PR).

@ChristophWurst
Copy link
Member Author

https://github.com/nextcloud/calendar-availability-vue/blob/main/src/CalendarAvailability.vue also uses two icon-* classes that need replacing

@GretaD
Copy link
Contributor

GretaD commented Jul 13, 2022

Mail

Note: These can be done only after vue loading icon is released

@GretaD
Copy link
Contributor

GretaD commented Aug 9, 2022

To do on contacts with stoppers

  • All the loading icons
  • Icon-add on - AppNavigationCaption used on RootNavigation.vue no icon slot
  • Icon-add on AppNavigationNew used on Contacts.vue - no icon slot

To do but that are leftovers, and will be done in one pr this week

  • icon external on rootnavigation
  • icon-checkmark entitysearchresult
  • icon-group/icon-user line 126 on settingsaddressbookshare
  • icon-history line 105 and icon-errorr on contactdetails

@GretaD
Copy link
Contributor

GretaD commented Aug 9, 2022

To do on contacts, no stoppers

  • icon-add on checkavailibility
  • icon-group/icon-user/icon-circle calendarlistitemsharingsearch
  • Icon-add on AppNavigationItem used on calendarlistnew
  • icons on avatarparticipationstatus

@ChristophWurst
Copy link
Member Author

nextcloud/contacts#2960 misses an icon upgrade.

@ChristophWurst
Copy link
Member Author

Bildschirmfoto vom 2022-10-10 12-36-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish overview Overview of other issues
Projects
Development

No branches or pull requests

2 participants