Migrate settings menu icons of contacts to material design icons #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2807 +/- ##
=============================================
+ Coverage 17.98% 68.47% +50.49%
Complexity 253 253
=============================================
Files 101 22 -79
Lines 3231 717 -2514
Branches 449 0 -449
=============================================
- Hits 581 491 -90
+ Misses 2456 226 -2230
+ Partials 194 0 -194 Continue to review full report at Codecov.
|
GretaD
commented
Jul 4, 2022
GretaD
commented
Jul 4, 2022
| @@ -52,7 +52,7 @@ | |||
| :disabled="loading.length > 0" | |||
| :placeholder="t('contacts', 'Unique password …')" | |||
| type="text" | |||
| @keyup.enter="saveUniquePassword" /> | |||
There was a problem hiding this comment.
phpstorm insist to remove this /
GretaD
added
3. to review
|
/backport to stable4.2 |
st3iny
force-pushed
the
migrate/settings-contacts
branch
from
0836de6
to
293ab26
Compare
st3iny
approved these changes
Jul 15, 2022
Signed-off-by: greta <gretadoci@gmail.com> Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
migrate/settings-contacts
branch
from
293ab26
to
252a525
Compare
st3iny
added
4. to release
|
yes, looks good! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref nextcloud/groupware#38
before
after
fixes #2777