Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate secondary message/envelope actions to material icons #6505

Merged
merged 1 commit into from
May 20, 2022
Merged

Migrate secondary message/envelope actions to material icons #6505

merged 1 commit into from
May 20, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst
Migrate secondary message/envelope actions to material icons
1b7cb06 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the v1.13.0 milestone May 19, 2022
@ChristophWurst ChristophWurst self-assigned this May 19, 2022
@JuliaKirschenheuter
Copy link
Contributor

Thank you for fixing!

Should we also change icons in actions inside of EnvelopePrimaryActions?

@ChristophWurst
Copy link
Member Author

Yes. They just need some styling fixes.

@GretaD
Copy link
Contributor

GretaD commented May 20, 2022 •
edited
Loading

Please notice on the top left the small arrow showing up when i click select or mark as spam

Kazam_screencast_00023.mp4

@ChristophWurst
Copy link
Member Author

Please notice on the top left the small arrow showing up when i click select or mark as spam

Have you compared this to main? I think it's caused by the popover menu.

GretaD
GretaD approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the icons are shown correctly

@JuliaKirschenheuter JuliaKirschenheuter merged commit f4f807d into main May 20, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the enhancement/material-icons-envelope-message-secondary-actions branch May 20, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@GretaD GretaD GretaD approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review enhancement performance 🚀
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
v1.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @JuliaKirschenheuter @GretaD