Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Nextcloud 25 design #4459

Closed
wants to merge 3 commits into from
Closed

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 5, 2022

  • Drop incompatible Nextcloud 22-24 support
  • Bump the version to reflect the breaking change(s)
  • Update ´@nextcloud/vue` to v7
    • Fix imports
    • Fix vue/vue-template-compiler version mismatches
  • Migrate icons.scss to a icons.css or process through webpack
  • Requires Migrate to material icons groupware#38

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst self-assigned this Sep 5, 2022
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews 2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request and removed 3. to review Waiting for reviews labels Sep 5, 2022
@ChristophWurst ChristophWurst added this to the v3.6.0 milestone Sep 5, 2022
@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #4459 (ebc0efa) into main (4beeca5) will not change coverage.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #4459   +/-   ##
=========================================
  Coverage     29.40%   29.40%           
  Complexity      330      330           
=========================================
  Files           220      220           
  Lines          7700     7700           
  Branches       1017     1017           
=========================================
  Hits           2264     2264           
  Misses         5436     5436           
Flag Coverage Δ
javascript 20.49% <0.00%> (ø)
php 68.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ppNavigationHeader/AppNavigationHeaderViewMenu.vue 0.00% <0.00%> (ø)
...components/AppNavigation/AppointmentConfigList.vue 0.00% <0.00%> (ø)
...ppointmentConfigList/AppointmentConfigListItem.vue 0.00% <0.00%> (ø)
...ts/AppNavigation/CalendarList/CalendarListItem.vue 0.00% <0.00%> (ø)
...alendarList/CalendarListItemSharingPublishItem.vue 0.00% <0.00%> (ø)
...ion/CalendarList/CalendarListItemSharingSearch.vue 0.00% <0.00%> (ø)
.../CalendarList/CalendarListItemSharingShareItem.vue 0.00% <0.00%> (ø)
...nts/AppNavigation/CalendarList/CalendarListNew.vue 0.00% <0.00%> (ø)
...Navigation/CalendarList/PublicCalendarListItem.vue 0.00% <0.00%> (ø)
...components/AppNavigation/CalendarList/Trashbin.vue 0.00% <0.00%> (ø)
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ChristophWurst
Copy link
Member Author

Split into multiple PRs

@ChristophWurst ChristophWurst deleted the enhancement/new-design branch September 9, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant