-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and tests for #2973 #2990
Conversation
/backport to stable5 |
@@ -20,6 +20,7 @@ | |||
"lint": "eslint --ext .js,.vue src", | |||
"lint:fix": "eslint --ext .js,.vue src --fix", | |||
"test": "jest --verbose", | |||
"test:coverage": "jest --verbose --coverage --no-cache", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used make test-coverage
and noticed this command doesn't work because the script test:coverage
wasn't present so i fixed this. It's not necessary but i think it's nice if the Makefile stages work :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples don't work.
Thank's for your quick feedback. Could you tell me what exactly does not work and how you tested this? Then i'll try to reproduce the issue. Thank you |
The MultiselectTags of your examples are not shown in the docs preview. See https://deploy-preview-2990--nextcloud-vue-components.netlify.app/#/Components/Multiselect?id=multiselecttags |
Ah okay, now i see. I didn't realize that the examples are interactive so my sample code is incomplete. Will fix this, thank's for pointing out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8117bc8
to
aa98906
Compare
Signed-off-by: R0Wi <ro.windey@gmail.com>
Signed-off-by: R0Wi <ro.windey@gmail.com>
aa98906
to
0e8ccc2
Compare
Missunderstood the docs code. I think now it should be fixed 👍 |
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org> Signed-off-by: Raimund Schlüßler <raimund.schluessler+github@mailbox.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works now. I just committed a very minor nitpick.
Like discussed in #2973