-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and tests for #2973 #2990
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
130 changes: 130 additions & 0 deletions
130
tests/unit/components/MultiselectTags/MultiselectTags.spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,130 @@ | ||
/** | ||
* @copyright Copyright (c) 2022 Robin Windey <ro.windey@gmail.com> | ||
* | ||
* @author Robin Windey <ro.windey@gmail.com> | ||
* | ||
* @license GNU AGPL version 3 or any later version | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
import { mount } from '@vue/test-utils' | ||
import { searchTags } from '../../../../src/components/MultiselectTags/api.js' | ||
import MultiselectTags from '../../../../src/components/MultiselectTags/MultiselectTags.vue' | ||
|
||
jest.mock('../../../../src/components/MultiselectTags/api.js') | ||
|
||
afterEach(() => { | ||
jest.clearAllMocks() | ||
}) | ||
|
||
describe('MultiselectTags.vue', () => { | ||
'use strict' | ||
|
||
it('Test that by default only 5 tags are shown', async () => { | ||
const numberOfTags = 42 | ||
const mockedTags = [] | ||
for (let i = 0; i < numberOfTags; i++) { | ||
mockedTags.push({ | ||
id: i, | ||
displayName: 'tag ' + i, | ||
canAssign: true, | ||
userAssignable: true, | ||
userVisible: true, | ||
}) | ||
} | ||
|
||
searchTags.mockResolvedValueOnce(mockedTags) | ||
|
||
const wrapper = mount(MultiselectTags, { | ||
propsData: { | ||
label: 'name', | ||
value: [], | ||
}, | ||
}) | ||
|
||
// Wait for data to be loaded | ||
await new Promise(process.nextTick) | ||
|
||
const options = wrapper.findAll('li.multiselect__element .multiselect__option') | ||
|
||
expect(searchTags).toHaveBeenCalledTimes(1) | ||
expect(options.length).toBe(5) | ||
}) | ||
|
||
it('Test that all available tags are shown if filter is null', async () => { | ||
const numberOfTags = 42 | ||
const mockedTags = [] | ||
for (let i = 0; i < numberOfTags; i++) { | ||
mockedTags.push({ | ||
id: i, | ||
displayName: 'tag ' + i, | ||
canAssign: true, | ||
userAssignable: true, | ||
userVisible: true, | ||
}) | ||
} | ||
|
||
searchTags.mockResolvedValueOnce(mockedTags) | ||
|
||
const wrapper = mount(MultiselectTags, { | ||
propsData: { | ||
label: 'name', | ||
value: [], | ||
filter: null, | ||
}, | ||
}) | ||
|
||
// Wait for data to be loaded | ||
await new Promise(process.nextTick) | ||
|
||
const options = wrapper.findAll('li.multiselect__element .multiselect__option') | ||
|
||
expect(searchTags).toHaveBeenCalledTimes(1) | ||
expect(options.length).toBe(numberOfTags) | ||
}) | ||
|
||
it('Test that filter is applied correctly', async () => { | ||
const numberOfTags = 42 | ||
const mockedTags = [] | ||
for (let i = 0; i < numberOfTags; i++) { | ||
mockedTags.push({ | ||
id: i, | ||
displayName: 'tag ' + i, | ||
canAssign: true, | ||
userAssignable: true, | ||
userVisible: true, | ||
}) | ||
} | ||
|
||
searchTags.mockResolvedValueOnce(mockedTags) | ||
|
||
const wrapper = mount(MultiselectTags, { | ||
propsData: { | ||
label: 'name', | ||
value: [], | ||
filter: (element, index) => index >= 40 && element.id >= 40, | ||
}, | ||
}) | ||
|
||
// Wait for data to be loaded | ||
await new Promise(process.nextTick) | ||
|
||
const options = wrapper.findAll('li.multiselect__element .multiselect__option') | ||
|
||
expect(searchTags).toHaveBeenCalledTimes(1) | ||
expect(options.length).toBe(2) | ||
}) | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used
make test-coverage
and noticed this command doesn't work because the scripttest:coverage
wasn't present so i fixed this. It's not necessary but i think it's nice if the Makefile stages work :-)