Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to filter the available tags #2973

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Allow to filter the available tags #2973

merged 2 commits into from
Aug 9, 2022

Conversation

nickvergessen
Copy link
Contributor

@nickvergessen nickvergessen added enhancement New feature or request 3. to review Waiting for reviews feature: select Related to the NcSelect* components labels Aug 8, 2022
@nickvergessen nickvergessen added this to the 6.0.0 milestone Aug 8, 2022
@nickvergessen
Allow to filter the available tags
9fb8e6f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the feature/noid/allow-to-filter-the-available-tags branch from 9abcf95 to 9fb8e6f Compare August 8, 2022 18:58
@nickvergessen nickvergessen mentioned this pull request Aug 8, 2022
Merged
12 tasks
@raimund-schluessler
Copy link
Contributor

Hm, interesting. We have a related PR here #2885 which aims at removing the limit of shown tags of currently 5.

How about we solve #2884 here as well, by removing :options-limit="5" and setting the default filter to slice the array to 5 elements to make it non-breaking? @nickvergessen @R0Wi

@raimund-schluessler raimund-schluessler mentioned this pull request Aug 8, 2022
Closed
@nickvergessen
Copy link
Contributor Author

Would be fine by me

@nickvergessen
Migrate the options-limit to be the default filter
54be3a3 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@R0Wi
Copy link
Contributor

R0Wi commented Aug 9, 2022

Nice solution for me, too, thanks! I think the only things missing are the docs and maybe some tests? If you're interested i could provide them in a separate PR

@raimund-schluessler
Copy link
Contributor

Nice solution for me, too, thanks! I think the only things missing are the docs and maybe some tests? If you're interested i could provide them in a separate PR

That would be very welcome, I think.

@nickvergessen
Copy link
Contributor Author

@R0Wi very much welcome as I'm very bad in JS/docs and more a consumer only

@nickvergessen
Copy link
Contributor Author

nickvergessen commented Aug 9, 2022 •
edited
Loading

Since this is non breaking I would then also backport it.

@nickvergessen
Copy link
Contributor Author

/backport to stable5

@skjnldsv skjnldsv merged commit 21a0ded into master Aug 9, 2022
@skjnldsv skjnldsv deleted the feature/noid/allow-to-filter-the-available-tags branch August 9, 2022 07:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 9, 2022
Merged
R0Wi pushed a commit that referenced this pull request Aug 9, 2022
Add docs and tests for #2973
8125532
@raimund-schluessler raimund-schluessler mentioned this pull request Aug 9, 2022
Closed
R0Wi added a commit that referenced this pull request Aug 9, 2022
@R0Wi
Add docs and tests for #2973
6062556
R0Wi added a commit that referenced this pull request Aug 9, 2022
@R0Wi
Add docs and tests for #2973
b5a0d86
@R0Wi R0Wi mentioned this pull request Aug 9, 2022
Merged
@juliusknorr juliusknorr mentioned this pull request Aug 11, 2022
Merged
R0Wi added a commit that referenced this pull request Aug 11, 2022
@R0Wi
Fix interactive docs for #2973
8117bc8
R0Wi added a commit that referenced this pull request Aug 12, 2022
@R0Wi
Fix interactive docs for #2973
aa98906
R0Wi added a commit that referenced this pull request Aug 12, 2022
@R0Wi
Add docs and tests for #2973
a097003 
Signed-off-by: R0Wi <ro.windey@gmail.com>
R0Wi added a commit that referenced this pull request Aug 12, 2022
@R0Wi
Fix interactive docs for #2973
0e8ccc2 
Signed-off-by: R0Wi <ro.windey@gmail.com>
raimund-schluessler added a commit that referenced this pull request Aug 12, 2022
@raimund-schluessler
Merge pull request #2990 from nextcloud/feature/add-docs-tests#2973
b4cbd40 
Add docs and tests for #2973
backportbot-nextcloud bot pushed a commit that referenced this pull request Aug 12, 2022
@R0Wi @backportbot-nextcloud
Add docs and tests for #2973
75f73ef 
Signed-off-by: R0Wi <ro.windey@gmail.com>
backportbot-nextcloud bot pushed a commit that referenced this pull request Aug 12, 2022
@R0Wi @backportbot-nextcloud
Fix interactive docs for #2973
8eed738 
Signed-off-by: R0Wi <ro.windey@gmail.com>
R0Wi added a commit that referenced this pull request Aug 12, 2022
@R0Wi
Merge pull request #3015 from nextcloud/backport/2990/stable5
5fabdde 
[stable5] Add docs and tests for #2973
@Pytal Pytal mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@R0Wi R0Wi Awaiting requested review from R0Wi

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: select Related to the NcSelect* components
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @raimund-schluessler @R0Wi @skjnldsv