test: Updated koa-router to tests to handle bug fixes from 13.0.1 #2578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsumners-nr
approved these changes
Sep 16, 2024
bizob2828
force-pushed
the
fix-koa-router-tests
branch
from
1a1654f
to
72cf908
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2578 +/- ##
==========================================
- Coverage 97.22% 97.18% -0.05%
==========================================
Files 291 291
Lines 45932 45932
==========================================
- Hits 44659 44639 -20
- Misses 1273 1293 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sumitsuthar
pushed a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
sumitsuthar
added a commit
to k2io/fork-node-newrelic
that referenced
this pull request
Sep 20, 2024
….0.1 (newrelic#2578)" This reverts commit 23e979c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
koa router had two fixes: koajs/router#189 and koajs/router#183 which broke our versioned tests. This PR handles the nuance from 13.0.1+
How to Test
Related Issues
I know a fix was made in #2576 but there was still one failing test, this fixes both.