chore: Fix testing of koa-router #2576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bizob2828
requested changes
Sep 16, 2024
| ] | ||
| ] | ||
| ] | ||
| ['Koa/Router: /', ['Nodejs/Middleware/Koa/terminalMiddleware//:second']] |
There was a problem hiding this comment.
this breaks older versions of koa, was this something that changed in behavior with newer versions?
There was a problem hiding this comment.
What is the original behavior?
There was a problem hiding this comment.
The current version of koa is still at 2
|
#2578 supersedes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #2573 and implements the changes required to make the tests work again.
/first/(.*)should become/first/{*any}