Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching zero-size blobs in S3 bucket provider #2394

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Fix fetching zero-size blobs in S3 bucket provider #2394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4ea34d
Fix fetching zero-size blobs in S3 bucket provider
romasku Oct 22, 2021
f4fef93
Add changelog
romasku Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.D/2394.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix fetching zero-size blob from S3 compatible bucket providers.
8 changes: 5 additions & 3 deletions neuro-sdk/src/neuro_sdk/buckets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,11 +513,13 @@ async def _upload_chunk() -> None:
@asyncgeneratorcontextmanager
async def fetch_blob(self, key: str, offset: int = 0) -> AsyncIterator[bytes]:
response = await self._client.get_object(
Bucket=self._bucket_name, Key=key, Range=f"bytes={offset}-"
Bucket=self._bucket_name,
Key=key,
Range=f"bytes={offset}-" if offset else "",
)
async with response["Body"] as stream:
async for chunk in stream.iter_chunks():
yield chunk[0]
async for chunk in stream.iter_any():
yield chunk

async def delete_blob(self, key: str) -> None:
await self._client.delete_object(Bucket=self._bucket_name, Key=key)
Expand Down