Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetching zero-size blobs in S3 bucket provider #2394

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

romasku
Copy link
Contributor

@romasku romasku commented Oct 22, 2021

No description provided.

@romasku romasku requested a review from asvetlov October 22, 2021 12:21
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2394 (f4fef93) into master (f4c7949) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
+ Coverage   71.48%   71.49%   +0.01%     
==========================================
  Files          67       67              
  Lines       11691    11691              
  Branches     1787     1787              
==========================================
+ Hits         8357     8359       +2     
+ Misses       3062     3061       -1     
+ Partials      272      271       -1     
Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/buckets.py 44.12% <0.00%> (ø)
neuro-cli/src/neuro_cli/file_logging.py 84.21% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c7949...f4fef93. Read the comment docs.

@romasku romasku merged commit 238bd51 into master Oct 25, 2021
@romasku romasku deleted the rs/fix-zero-size-blobs branch October 25, 2021 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants