Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] release version bugfix (#290) #291

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Nov 30, 2023

Cherry pick for bug #290:
release build asking for dated versions of nm repos, for example asking for sparsezoo~=1.6.0.202308 instead of sparsezoo~=1.6.0

This PR fixes that in 1.6 release

@rahul-tuli rahul-tuli self-assigned this Nov 30, 2023
@rahul-tuli rahul-tuli added bug Something isn't working mle-team labels Nov 30, 2023
@dhuangnm
Copy link
Member

@rahul-tuli this PR looks still target the main branch? For cherry-pick, please target release/1.6. Thanks.

@rahul-tuli rahul-tuli changed the base branch from main to release/1.6 November 30, 2023 17:27
@rahul-tuli
Copy link
Member Author

@rahul-tuli this PR looks still target the main branch? For cherry-pick, please target release/1.6.

Thanks Dan, updated!

@dhuangnm dhuangnm self-requested a review November 30, 2023 18:33
@rahul-tuli rahul-tuli merged commit 85d29a6 into release/1.6 Nov 30, 2023
3 of 4 checks passed
@rahul-tuli rahul-tuli deleted the cherry-pick-release-version-bugfix branch November 30, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mle-team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants