Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Release Build trying to install dated versions of nm_deps #290

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[Fix] Release Build trying to install dated versions of nm_deps #290

merged 2 commits into from
Nov 30, 2023

Conversation

rahul-tuli
Copy link
Member

Append date to major_minor_version only when building a nightly wheel

Tested by setting is_release to True
Also moves Neural Magic dependencies to _nm_deps as is the case for our other repos

@rahul-tuli rahul-tuli marked this pull request as ready for review November 30, 2023 17:06
@rahul-tuli rahul-tuli self-assigned this Nov 30, 2023
@rahul-tuli rahul-tuli added bug Something isn't working mle-team labels Nov 30, 2023
dsikka
dsikka reviewed Nov 30, 2023
View reviewed changes
Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason the deps were moved was because of the finetuning pathway. That's probably legacy at this point but does this change break it?

@rahul-tuli
Copy link
Member Author

the reason the deps were moved was because of the finetuning pathway. That's probably legacy at this point but does this change break it?

No this would not break it, as install requires was updated to include _nm_deps as well

@dsikka dsikka self-requested a review November 30, 2023 17:19
@rahul-tuli rahul-tuli merged commit bdd86d5 into main Nov 30, 2023
3 of 4 checks passed
@rahul-tuli rahul-tuli deleted the bugfix-sparsify-release-version branch November 30, 2023 18:04
rahul-tuli added a commit that referenced this pull request Nov 30, 2023
@rahul-tuli
[Cherry pick] release version bugfix (#290) (#291)
85d29a6 
* [Fix] Append date to major_minor version only when
building a nightly release

* missed onnxruntime-gpu
@rahul-tuli rahul-tuli mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Satrat Satrat Satrat approved these changes

@dsikka dsikka dsikka approved these changes

@bfineran bfineran Awaiting requested review from bfineran

@markurtz markurtz Awaiting requested review from markurtz

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees

@rahul-tuli rahul-tuli

Labels
bug Something isn't working mle-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahul-tuli @Satrat @dsikka