Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Export Refactor][Image Classification]
create_dummy_input
function #1880[Export Refactor][Image Classification]
create_dummy_input
function #1880Changes from 14 commits
6d8991c
059ceab
b390c2e
c2c8444
6ce6ba5
6f3e5e7
5dfbdcd
042c193
29cfa1d
ab73aec
f628532
b93b634
e7606cd
ea9cb61
9572e0b
6e5f575
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we expect this optional value to flow from the create model function? thinking we need to accept
**kwargs
in this signature to avoid edge cases for extra kwargs (ie arch key that we'll need)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the flow is quite elegant and well-designed:
Maybe i'd call the variable more generically, i.e.
data_loader
instead ofvalidation_loader