-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Export Refactor][Image Classification] create_dummy_input
function
#1880
Merged
dbogunowicz
merged 16 commits into
feature/damian/feature_branch_export
from
feature/damian/create_dummy_inputs_ic
Dec 11, 2023
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6d8991c
initial commit
dbogunowicz 059ceab
looking good, time to cleanup
dbogunowicz b390c2e
Delete src/sparseml/export/helpers.py
dbogunowicz c2c8444
Delete tests/sparseml/export/test_helpers.py
dbogunowicz 6ce6ba5
ready for review
dbogunowicz 6f3e5e7
Merge branch 'feature/damian/create_model_ic' of github.com:neuralmag…
dbogunowicz 5dfbdcd
improve design
dbogunowicz 042c193
tests pass
dbogunowicz 29cfa1d
reuse _validate_dataset_num_classes
dbogunowicz ab73aec
initial commit
dbogunowicz f628532
Update src/sparseml/pytorch/image_classification/integration_helper_f…
dbogunowicz b93b634
Update src/sparseml/pytorch/image_classification/integration_helper_f…
dbogunowicz e7606cd
ready for review
dbogunowicz ea9cb61
Update src/sparseml/export/export.py
dbogunowicz 9572e0b
Update src/sparseml/integration_helper_functions.py
dbogunowicz 6e5f575
Merge remote-tracking branch 'origin/feature/damian/feature_branch_ex…
dbogunowicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do we expect this optional value to flow from the create model function? thinking we need to accept
**kwargs
in this signature to avoid edge cases for extra kwargs (ie arch key that we'll need)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the flow is quite elegant and well-designed:
Maybe i'd call the variable more generically, i.e.
data_loader
instead ofvalidation_loader