Fix YOLOv8 validation when custom dataset yaml is provided #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
previously approved these changes
Apr 20, 2023
dbogunowicz
approved these changes
Apr 20, 2023
shubhra
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pycocotools pathway for model validation expects a "Path" object for the data['path'] entry. When the user provides a complete path to a yaml file (or when --dataset-path is provided) this entry remains a string, which leads to an error when doing the pycocotools evaluation.
This is a failure on ultralytics side, but we can fix in the integration since we override the validator class.
Testing plan: The fix allowed me to use "dataset-path" as below:
sparseml.ultralytics.val
--model zoo:cv/detection/yolov8-n/pytorch/ultralytics/coco/base-none
--data coco.yaml
--dataset-path /home/alexandre/datasets/coco
(dataset-path is implemented by 1. copying ultralytics' coco.yaml to the local path, 2. overwriting the dataset path in the yaml file, 3. replacing the data argument with the complete path to edited yaml file.)