Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency gopacket #723

Closed
wants to merge 1 commit into from
Closed

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 20, 2024

No description provided.

Copy link

openshift-ci bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 20, 2024
Copy link

New image:
quay.io/netobserv/flowlogs-pipeline:0804d1a

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=0804d1a make set-flp-image

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.47%. Comparing base (2ea1a7c) to head (b8a298d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   65.47%   65.47%           
=======================================
  Files         108      108           
  Lines        7026     7026           
=======================================
  Hits         4600     4600           
  Misses       2108     2108           
  Partials      318      318           
Flag Coverage Δ
unittests 65.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@msherif1234
Copy link
Contributor

don't you need to wait for netobserv/netobserv-ebpf-agent#416 then update the agent instead ?

@jotak
Copy link
Member Author

jotak commented Sep 20, 2024

that's only a temporary PR (that's why it's a draft) .. it is not meant to be merged but I wanted to verify with perf tests if it helps or not, given that there seem to be several regressions

@jotak jotak closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants