Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NETOBSERV-1889: decoupling, use gopacket fork #416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NETOBSERV-1889: decoupling, use gopacket fork #416

wants to merge 1 commit into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Sep 20, 2024 •
edited
Loading

  • Decouple some packages so that FLP has less to pull (currently it pulls all cilium & bpf etc.)
    -> new "model" package split from "flow"
    -> new "tracer" package split from "ebpf"
    -> isolate packet-related dependencies so that gopacket isn't a transitive dependency in FLP

  • replace google/gopacket with gopacket/gopacket ; it's a fork, the former being unmaintained.

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jotak
NETOBSERV-1889: decoupling, use gopacket fork
9cacdb9 
- Decouple some packages so that FLP has less to pull (currently it
  pulls all cilium & bpf etc.)
  -> new "model" package split from "flow"
  -> new "tracer" package split from "ebpf"
  -> isolate packet-related dependencies so that gopacket isn't a
transitive dependency in FLP

- replace google/gopacket with gopacket/gopacket ; it's a fork, the
  former being unmaintained.
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 20, 2024 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-1889 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

  • Decouple some packages so that FLP has less to pull (currently it pulls all cilium & bpf etc.)
    -> new "model" package split from "flow"
    -> new "tracer" package split from "ebpf"
    -> isolate packet-related dependencies so that gopacket isn't a transitive dependency in FLP

  • replace google/gopacket with gopacket/gopacket ; it's a fork, the former being unmaintained.

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 20, 2024 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-1889 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to this:

  • Decouple some packages so that FLP has less to pull (currently it pulls all cilium & bpf etc.)
    -> new "model" package split from "flow"
    -> new "tracer" package split from "ebpf"
    -> isolate packet-related dependencies so that gopacket isn't a transitive dependency in FLP

  • replace google/gopacket with gopacket/gopacket ; it's a fork, the former being unmaintained.

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.25397% with 206 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d975af5). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/tracer/tracer.go 0.00% 90 Missing ⚠️
pkg/decode/packets/decode_protobuf_packets.go 0.00% 47 Missing ⚠️
pkg/tracer/flow_filter.go 26.08% 17 Missing ⚠️
pkg/agent/agent.go 15.38% 11 Missing ⚠️
pkg/agent/packets_agent.go 0.00% 10 Missing ⚠️
pkg/exporter/ipfix.go 0.00% 8 Missing ⚠️
pkg/flow/perfbuffer.go 0.00% 8 Missing ⚠️
pkg/flow/tracer_perf.go 0.00% 4 Missing ⚠️
pkg/tracer/tracer_legacy.go 0.00% 4 Missing ⚠️
pkg/exporter/direct_flp.go 33.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #416   +/-   ##
=======================================
  Coverage        ?   30.06%           
=======================================
  Files           ?       50           
  Lines           ?     4071           
  Branches        ?        0           
=======================================
  Hits            ?     1224           
  Misses          ?     2741           
  Partials        ?      106
Flag Coverage Δ
unittests 30.06% <18.25%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/decode/decode_protobuf.go 27.07% <100.00%> (ø)
pkg/exporter/grpc_proto.go 71.42% <100.00%> (ø)
pkg/exporter/kafka_proto.go 69.23% <100.00%> (ø)
pkg/flow/account.go 90.00% <100.00%> (ø)
pkg/flow/decorator.go 100.00% <100.00%> (ø)
pkg/flow/limiter.go 57.14% <100.00%> (ø)
pkg/flow/tracer_map.go 79.48% <100.00%> (ø)
pkg/model/packet_record.go 0.00% <ø> (ø)
pkg/model/record.go 72.60% <ø> (ø)
pkg/test/export_fake.go 80.00% <100.00%> (ø)
... and 15 more

@jpinsonneau jpinsonneau added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 20, 2024
@github-actions GitHub Actions
Copy link

New image:
quay.io/netobserv/netobserv-ebpf-agent:a05b18c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a05b18c make set-agent-image

@msherif1234
Copy link
Contributor

/lgtm
lets wait for manual cli verification make sure no new issues with the new pkg

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
@msherif1234 msherif1234 mentioned this pull request Sep 20, 2024
Closed
@jpinsonneau
Copy link
Contributor

/lgtm lets wait for manual cli verification make sure no new issues with the new pkg

Tested the cli manually and works fine with ebpf a05b18c image

@msherif1234 msherif1234 removed the lgtm label Sep 20, 2024
@jotak jotak mentioned this pull request Sep 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msherif1234 msherif1234 Awaiting requested review from msherif1234

Assignees

@msherif1234 msherif1234

Labels
jira/valid-reference ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jotak @openshift-ci-robot @msherif1234 @jpinsonneau