Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass configured compression param to image generation #8363

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jul 11, 2024

We need to pass on the configured compression param during image layer generation.

This was an oversight of #8106, and the likely cause why #8288 didn't bring any interesting regressions.

Part of #5431

@arpad-m arpad-m requested a review from skyzh July 11, 2024 20:06
@arpad-m arpad-m requested a review from a team as a code owner July 11, 2024 20:06
Copy link

github-actions bot commented Jul 11, 2024

3073 tests run: 2958 passed, 0 failed, 115 skipped (full report)


Flaky tests (3)

Postgres 14

  • test_isolation[None]: debug
  • test_subscriber_restart: release
  • test_s3_eviction[0.2-False]: release

Code coverage* (full report)

  • functions: 32.7% (6967 of 21312 functions)
  • lines: 50.1% (54893 of 109531 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
f74d8dc at 2024-07-11T23:30:22.499Z :recycle:

@arpad-m arpad-m merged commit 30bbfde into main Jul 11, 2024
66 checks passed
@arpad-m arpad-m deleted the arpad/compression_9 branch July 11, 2024 23:43
@arpad-m arpad-m mentioned this pull request Jul 12, 2024
skyzh pushed a commit that referenced this pull request Jul 15, 2024
We need to pass on the configured compression param during image layer
generation.

This was an oversight of #8106, and the likely cause why #8288 didn't
bring any interesting regressions.

Part of #5431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants