Skip to content

Commit

Permalink
Pass configured compression param to image generation (#8363)
Browse files Browse the repository at this point in the history
We need to pass on the configured compression param during image layer
generation.

This was an oversight of #8106, and the likely cause why #8288 didn't
bring any interesting regressions.

Part of #5431
  • Loading branch information
arpad-m committed Jul 11, 2024
1 parent 82b9a44 commit 30bbfde
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pageserver/src/tenant/storage_layer/image_layer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,11 @@ impl ImageLayerWriterInner {
ctx: &RequestContext,
) -> anyhow::Result<()> {
ensure!(self.key_range.contains(&key));
let (_img, res) = self.blob_writer.write_blob(img, ctx).await;
let compression = self.conf.image_compression;
let (_img, res) = self
.blob_writer
.write_blob_maybe_compressed(img, ctx, compression)
.await;
// TODO: re-use the buffer for `img` further upstack
let off = res?;

Expand Down

1 comment on commit 30bbfde

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3135 tests run: 3007 passed, 1 failed, 127 skipped (full report)


Failures on Postgres 15

  • test_pg_regress[4]: debug
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pg_regress[debug-pg15-4]"
Flaky tests (5)

Postgres 16

  • test_tenant_creation_fails: debug

Postgres 15

  • test_storage_controller_heartbeats[failure2]: debug

Postgres 14

  • test_statvfs_pressure_usage: debug
  • test_isolation[4]: debug
  • test_s3_eviction[0.2-True]: release

Test coverage report is not available

The comment gets automatically updated with the latest test results
30bbfde at 2024-07-12T01:04:54.590Z :recycle:

Please sign in to comment.