Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: increase approx size equal threshold to avoid test_lsn_lease_size flakiness #8282

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Jul 5, 2024

Summary of changes

Increase the assert_size_approx_equal threshold to avoid flakiness of test_lsn_lease_size. Still needs more investigation to fully resolve #8293.

  • Also set autovacuum=off for the endpoint we are running in the test.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

…ize flakiness

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
@yliang412 yliang412 requested review from jcsp and problame July 5, 2024 14:57
Copy link

github-actions bot commented Jul 5, 2024

3042 tests run: 2927 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6939 of 21280 functions)
  • lines: 50.0% (54556 of 109068 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
cac6ee6 at 2024-07-08T20:06:12.801Z :recycle:

@yliang412
Copy link
Contributor Author

Followup: on PG16, it's much larger (allure).

Copy link
Member

@arpad-m arpad-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good as a temporary workaround, later we can find a better fix

test_runner/regress/test_tenant_size.py Outdated Show resolved Hide resolved
yliang412 and others added 2 commits July 8, 2024 14:01
@yliang412 yliang412 self-assigned this Jul 8, 2024
@yliang412 yliang412 force-pushed the yuchen/fix-lsn-lease-size-test branch from cf0b3b7 to cac6ee6 Compare July 8, 2024 19:21
@problame problame removed their request for review July 8, 2024 19:51
@yliang412 yliang412 enabled auto-merge (squash) July 8, 2024 20:23
@yliang412 yliang412 merged commit d9c1068 into main Jul 8, 2024
66 checks passed
@yliang412 yliang412 deleted the yuchen/fix-lsn-lease-size-test branch July 8, 2024 20:50
skyzh pushed a commit that referenced this pull request Jul 15, 2024
…size` flakiness (#8282)

## Summary of changes

Increase the `assert_size_approx_equal` threshold to avoid flakiness of
`test_lsn_lease_size`. Still needs more investigation to fully resolve
#8293.

- Also set `autovacuum=off` for the endpoint we are running in the test.

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_lsn_lease_size flaky
3 participants