Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_lsn_lease_size flaky #8293

Closed
skyzh opened this issue Jul 5, 2024 · 2 comments · Fixed by #8282
Closed

test_lsn_lease_size flaky #8293

skyzh opened this issue Jul 5, 2024 · 2 comments · Fixed by #8282
Assignees
@yliang412
Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug

Comments

@skyzh
Copy link
Member

skyzh commented Jul 5, 2024

https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8291/9811816038/index.html#suites/d70040d097c5c7c438e421e0416d69ce/8b9d1e05e6c02925

AssertionError: assert 312497288 == 312316992 ± 3.3e+04
  comparison failed
  Obtained: 312497288
  Expected: 312316992 ± 3.3e+04

cc @yliang412 do you have any idea or I/we can look into it next week?
@skyzh skyzh added t/bug Issue Type: Bug c/storage/pageserver Component: storage: pageserver labels Jul 5, 2024
@skyzh skyzh mentioned this issue Jul 5, 2024
Merged
@skyzh skyzh changed the title test_lsn_lease_size unstable test_lsn_lease_size flaky Jul 5, 2024
@yliang412
Copy link
Contributor

Tried to resolve by having a larger threshold in #8282, but I feel this won't fix the root cause.

@yliang412 yliang412 self-assigned this Jul 8, 2024
@yliang412
Copy link
Contributor

Relevant Reports:

@yliang412 yliang412 mentioned this issue Jul 8, 2024
Merged
5 tasks
skyzh pushed a commit that referenced this issue Jul 15, 2024
@yliang412 @skyzh
tests: increase approx size equal threshold to avoid `test_lsn_lease_…
0b6492e 
…size` flakiness (#8282)

## Summary of changes

Increase the `assert_size_approx_equal` threshold to avoid flakiness of
`test_lsn_lease_size`. Still needs more investigation to fully resolve
#8293.

- Also set `autovacuum=off` for the endpoint we are running in the test.

Signed-off-by: Yuchen Liang <yuchen@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yliang412 yliang412

Labels
c/storage/pageserver Component: storage: pageserver t/bug Issue Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: increase approx size equal threshold to avoid test_lsn_lease_size flakiness neondatabase/neon
2 participants
@skyzh @yliang412