New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(build-tools): Remove libpq from build image #8206

Merged

bayandin merged 3 commits into main from bayandin/remove-libpq-from-build-tools

Jul 1, 2024

Member

bayandin commented Jun 28, 2024

Problem

We use build-tools image as a base image to build other images, and it has a pretty old libpq-dev installed (v13, it wasn't that old until I removed system Postgres 14 from build-tools image in #6540)

Summary of changes

Remove libpq-dev from build-tools image
Set LD_LIBRARY_PATH for tests (for different Postgres binaries that we use, like psql and pgbench)
Set PQ_LIB_DIR to build Storage Controller
Set LD_LIBRARY_PATH/DYLD_LIBRARY_PATH in the Storage Controller where it calls Postgres binaries

Checklist before requesting a review

I have performed a self-review of my code.
If it is a core feature, I have added thorough tests.
Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

Do not forget to reformat commit message to not include the above checklist

bayandin requested a review from jcsp

June 28, 2024 17:50

bayandin added 2 commits

June 28, 2024 23:45


          CI(build-tools): don't install libpq-dev

51303e1


          CI: Set PQ_LIB_DIR & LD_LIBRARY_PATH

679e633

bayandin force-pushed the bayandin/remove-libpq-from-build-tools branch from 637702e to 762f60f Compare

June 28, 2024 22:45

github-actions bot commented Jun 28, 2024 •

edited

Loading

2940 tests run: 2823 passed, 0 failed, 117 skipped (full report)

Flaky tests (2)

Postgres 14

test_location_conf_churn[3]: debug
test_subscriber_restart: release

Code coverage* (full report)

functions: 32.7% (6905 of 21128 functions)
lines: 50.0% (54133 of 108165 lines)

* collected from Rust tests only

_{The comment gets automatically updated with the latest test results
118ba1d at 2024-06-29T10:41:30.727Z :recycle:}


          Storage Controller: set LD_LIBRARY_PATH

118ba1d

bayandin force-pushed the bayandin/remove-libpq-from-build-tools branch from 762f60f to 118ba1d Compare

June 29, 2024 09:47

jcsp approved these changes

View reviewed changes

bayandin merged commit e823b92 into main

67 checks passed

bayandin deleted the bayandin/remove-libpq-from-build-tools branch

July 1, 2024 12:11

bayandin mentioned this pull request

CI(gather-rust-build-stats): fix build with libpq #8219

Merged

5 tasks

bayandin added a commit that referenced this pull request


          CI(gather-rust-build-stats): fix build with libpq (#8219)

9c32604

## Problem
I've missed setting `PQ_LIB_DIR` in
#8206 in
`gather-rust-build-stats` job and it fails now:
```
  = note: /usr/bin/ld: cannot find -lpq
          collect2: error: ld returned 1 exit status
          

error: could not compile `storage_controller` (bin "storage_controller") due to 1 previous error
```

https://github.com/neondatabase/neon/actions/runs/9743960062/job/26888597735

## Summary of changes
- Set `PQ_LIB_DIR` for `gather-rust-build-stats` job

VladLazar pushed a commit that referenced this pull request


          CI(build-tools): Remove libpq from build image (#8206)

1ec1c6f

## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries

VladLazar pushed a commit that referenced this pull request


          CI(gather-rust-build-stats): fix build with libpq (#8219)

d5759aa

## Problem
I've missed setting `PQ_LIB_DIR` in
#8206 in
`gather-rust-build-stats` job and it fails now:
```
  = note: /usr/bin/ld: cannot find -lpq
          collect2: error: ld returned 1 exit status
          

error: could not compile `storage_controller` (bin "storage_controller") due to 1 previous error
```

https://github.com/neondatabase/neon/actions/runs/9743960062/job/26888597735

## Summary of changes
- Set `PQ_LIB_DIR` for `gather-rust-build-stats` job

VladLazar pushed a commit that referenced this pull request


          CI(build-tools): Remove libpq from build image (#8206)

bdf31b7

## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries

VladLazar pushed a commit that referenced this pull request


          CI(gather-rust-build-stats): fix build with libpq (#8219)

## Problem
I've missed setting `PQ_LIB_DIR` in
#8206 in
`gather-rust-build-stats` job and it fails now:
```
  = note: /usr/bin/ld: cannot find -lpq
          collect2: error: ld returned 1 exit status
          

error: could not compile `storage_controller` (bin "storage_controller") due to 1 previous error
```

https://github.com/neondatabase/neon/actions/runs/9743960062/job/26888597735

## Summary of changes
- Set `PQ_LIB_DIR` for `gather-rust-build-stats` job

VladLazar pushed a commit that referenced this pull request


          CI(build-tools): Remove libpq from build image (#8206)

c53f81d

## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries

VladLazar pushed a commit that referenced this pull request


          CI(gather-rust-build-stats): fix build with libpq (#8219)

bc4b90d

## Problem
I've missed setting `PQ_LIB_DIR` in
#8206 in
`gather-rust-build-stats` job and it fails now:
```
  = note: /usr/bin/ld: cannot find -lpq
          collect2: error: ld returned 1 exit status
          

error: could not compile `storage_controller` (bin "storage_controller") due to 1 previous error
```

https://github.com/neondatabase/neon/actions/runs/9743960062/job/26888597735

## Summary of changes
- Set `PQ_LIB_DIR` for `gather-rust-build-stats` job

VladLazar pushed a commit that referenced this pull request


          CI(build-tools): Remove libpq from build image (#8206)

575c8e0

## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries

VladLazar pushed a commit that referenced this pull request


          CI(gather-rust-build-stats): fix build with libpq (#8219)

5cb73c3

## Problem
I've missed setting `PQ_LIB_DIR` in
#8206 in
`gather-rust-build-stats` job and it fails now:
```
  = note: /usr/bin/ld: cannot find -lpq
          collect2: error: ld returned 1 exit status
          

error: could not compile `storage_controller` (bin "storage_controller") due to 1 previous error
```

https://github.com/neondatabase/neon/actions/runs/9743960062/job/26888597735

## Summary of changes
- Set `PQ_LIB_DIR` for `gather-rust-build-stats` job

VladLazar pushed a commit that referenced this pull request


          CI(build-tools): Remove libpq from build image (#8206)

325294b

## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries

VladLazar pushed a commit that referenced this pull request


          CI(gather-rust-build-stats): fix build with libpq (#8219)

504ca77

## Problem
I've missed setting `PQ_LIB_DIR` in
#8206 in
`gather-rust-build-stats` job and it fails now:
```
  = note: /usr/bin/ld: cannot find -lpq
          collect2: error: ld returned 1 exit status
          

error: could not compile `storage_controller` (bin "storage_controller") due to 1 previous error
```

https://github.com/neondatabase/neon/actions/runs/9743960062/job/26888597735

## Summary of changes
- Set `PQ_LIB_DIR` for `gather-rust-build-stats` job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet