Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI(build-tools): don't install Postgres 14 #6540

Merged
merged 2 commits into from
Jun 26, 2024
Merged

CI(build-tools): don't install Postgres 14 #6540

merged 2 commits into from
Jun 26, 2024

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Jan 31, 2024 •
edited
Loading

Problem

We install Postgres 14 in build-tools image, but we don't really need it. We use Postgres binaries that we build ourselves.

Summary of changes

  • Remove Postgresql 14 installation from build-tools image

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2024 •
edited
Loading

2910 tests run: 2793 passed, 0 failed, 117 skipped (full report)

Code coverage* (full report)

  • functions: 32.8% (6895 of 21016 functions)
  • lines: 50.3% (53907 of 107167 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
23dc8d8 at 2024-06-26T13:39:32.340Z :recycle:

@bayandin bayandin force-pushed the bayandin/remove-postgres-from-build-tools branch from 8d8a2fb to 23dc8d8 Compare June 26, 2024 12:26
@Bodobolero Bodobolero self-requested a review June 26, 2024 12:31
Bodobolero
Bodobolero approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Bodobolero Bodobolero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we don't know if all users of that container that need Postgres-client add their own built or downloaded postgres client binaries to the path but expect the prior behavior that it is already there. So after the merging the PR we need to watch the different CI runs for potential failures caused by this - it is easily detectable by your assertion that the postgres client tool path was resolved correctly, though

@bayandin bayandin marked this pull request as ready for review June 26, 2024 15:27
@bayandin bayandin changed the title build-tools: don't install Postgres 14 CI(build-tools): don't install Postgres 14 Jun 26, 2024
@bayandin bayandin merged commit 5af9660 into main Jun 26, 2024
65 of 66 checks passed
@bayandin bayandin deleted the bayandin/remove-postgres-from-build-tools branch June 26, 2024 15:37
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
@bayandin @conradludgate
CI(build-tools): don't install Postgres 14 (#6540)
e6ecd2f 
## Problem

We install Postgres 14 in `build-tools` image, but we don't need
it. We use Postgres binaries, which we build ourselves.

## Summary of changes
- Remove Postgresql 14 installation from `build-tools` image
@bayandin bayandin mentioned this pull request Jun 28, 2024
Merged
5 tasks
bayandin added a commit that referenced this pull request Jul 1, 2024
@bayandin
CI(build-tools): Remove libpq from build image (#8206)
e823b92 
## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(build-tools): Remove libpq from build image (#8206)
1ec1c6f 
## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(build-tools): Remove libpq from build image (#8206)
bdf31b7 
## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(build-tools): Remove libpq from build image (#8206)
c53f81d 
## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(build-tools): Remove libpq from build image (#8206)
575c8e0 
## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
@bayandin @VladLazar
CI(build-tools): Remove libpq from build image (#8206)
325294b 
## Problem
We use `build-tools` image as a base image to build other images, and it
has a pretty old `libpq-dev` installed (v13; it wasn't that old until I
removed system Postgres 14 from `build-tools` image in
#6540)

## Summary of changes
- Remove `libpq-dev` from `build-tools` image
- Set `LD_LIBRARY_PATH` for tests (for different Postgres binaries that
we use, like psql and pgbench)
- Set `PQ_LIB_DIR` to build Storage Controller
- Set `LD_LIBRARY_PATH`/`DYLD_LIBRARY_PATH` in the Storage Controller
where it calls Postgres binaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bodobolero Bodobolero Bodobolero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bayandin @Bodobolero