Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use aux file v2 policy in benchmarks #8174

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 26, 2024

Problem

Use aux file v2 in benchmarks.

Summary of changes

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Jun 26, 2024
Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Jun 26, 2024

Decided not to enable v2 for all tests because some tests require the default value to be the same across regress + pageserver config. Only enabled it for benchmarks.

@skyzh skyzh changed the title test: use aux file v2 policy by default test: use aux file v2 policy in benchmarks Jun 26, 2024
Copy link

github-actions bot commented Jun 26, 2024

3047 tests run: 2921 passed, 0 failed, 126 skipped (full report)


Flaky tests (4)

Postgres 15

  • test_subscriber_restart: release
  • test_compaction_induced_by_detaches_in_history: release

Postgres 14

  • test_pgbench_intensive_init_workload[neon_on-github-actions-selfhosted-1000]: release
  • test_location_conf_churn[3]: debug

Code coverage* (full report)

  • functions: 32.6% (6894 of 21124 functions)
  • lines: 50.0% (53933 of 107928 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
e9600aa at 2024-06-26T21:21:31.305Z :recycle:

@skyzh skyzh enabled auto-merge (squash) June 26, 2024 20:21
@skyzh skyzh merged commit 04b2ac3 into main Jun 26, 2024
68 checks passed
@skyzh skyzh deleted the skyzh/aux-policy-test branch June 26, 2024 20:33
conradludgate pushed a commit that referenced this pull request Jun 27, 2024
Use aux file v2 in benchmarks.

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants