Skip to content

Commit

Permalink
test: use aux file v2 policy in benchmarks (#8174)
Browse files Browse the repository at this point in the history
Use aux file v2 in benchmarks.

Signed-off-by: Alex Chi Z <chi@neon.tech>
  • Loading branch information
skyzh committed Jun 26, 2024
1 parent c39d5b0 commit 04b2ac3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
12 changes: 5 additions & 7 deletions test_runner/fixtures/neon_fixtures.py
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ def init_start(
timeline_id=env.initial_timeline,
shard_count=initial_tenant_shard_count,
shard_stripe_size=initial_tenant_shard_stripe_size,
aux_file_v2=self.pageserver_aux_file_policy,
aux_file_policy=self.pageserver_aux_file_policy,
)
assert env.initial_tenant == initial_tenant
assert env.initial_timeline == initial_timeline
Expand Down Expand Up @@ -1604,7 +1604,7 @@ def create_tenant(
shard_stripe_size: Optional[int] = None,
placement_policy: Optional[str] = None,
set_default: bool = False,
aux_file_v2: Optional[AuxFileStore] = None,
aux_file_policy: Optional[AuxFileStore] = None,
) -> Tuple[TenantId, TimelineId]:
"""
Creates a new tenant, returns its id and its initial timeline's id.
Expand All @@ -1629,13 +1629,11 @@ def create_tenant(
)
)

if aux_file_v2 is AuxFileStore.V2:
if aux_file_policy is AuxFileStore.V2:
args.extend(["-c", "switch_aux_file_policy:v2"])

if aux_file_v2 is AuxFileStore.V1:
elif aux_file_policy is AuxFileStore.V1:
args.extend(["-c", "switch_aux_file_policy:v1"])

if aux_file_v2 is AuxFileStore.CrossValidation:
elif aux_file_policy is AuxFileStore.CrossValidation:
args.extend(["-c", "switch_aux_file_policy:cross-validation"])

if set_default:
Expand Down
3 changes: 2 additions & 1 deletion test_runner/performance/test_logical_replication.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

import pytest
from fixtures.log_helper import log
from fixtures.neon_fixtures import NeonEnv, PgBin, logical_replication_sync
from fixtures.neon_fixtures import AuxFileStore, NeonEnv, PgBin, logical_replication_sync


@pytest.mark.parametrize("pageserver_aux_file_policy", [AuxFileStore.V2])
@pytest.mark.timeout(1000)
def test_logical_replication(neon_simple_env: NeonEnv, pg_bin: PgBin, vanilla_pg):
env = neon_simple_env
Expand Down

1 comment on commit 04b2ac3

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3022 tests run: 2895 passed, 1 failed, 126 skipped (full report)


Failures on Postgres 14

  • test_pgbench_intensive_init_workload[neon_on-github-actions-selfhosted-1000]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pgbench_intensive_init_workload[neon_on-release-pg14-github-actions-selfhosted-1000]"
Flaky tests (1)

Postgres 16

Code coverage* (full report)

  • functions: 32.6% (6892 of 21116 functions)
  • lines: 50.0% (53935 of 107861 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
04b2ac3 at 2024-06-26T22:02:45.195Z :recycle:

Please sign in to comment.