Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivate page bench test in CI after ignoring CopyFail error in pageserver #8023

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

Bodobolero
Copy link
Contributor

Problem

Testcase page bench test_pageserver_max_throughput_getpage_at_latest_lsn had been deactivated because it was flaky.

We now ignore copy fail error messages like in

env.pageserver.allowed_errors.append(
# https://github.com/neondatabase/neon/issues/6925
r".*query handler for.*pagestream.*failed: unexpected message: CopyFail during COPY.*"
)

and want to reactivate it to see it it is still flaky

Summary of changes

  • reactivate the test in CI
  • ignore CopyFail error message during page bench test cases

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

Copy link

github-actions bot commented Jun 12, 2024

3298 tests run: 3147 passed, 0 failed, 151 skipped (full report)


Code coverage* (full report)

  • functions: 31.6% (6625 of 20989 functions)
  • lines: 48.6% (51485 of 106042 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
8c6c332 at 2024-06-12T14:08:07.568Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get run benchmarks in the PR, you need to add a run-benchmarks label to it, and they'll run for the next commit

test_runner/performance/pageserver/util.py Outdated Show resolved Hide resolved
@Bodobolero Bodobolero added the run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label label Jun 12, 2024
@Bodobolero
Copy link
Contributor Author

Merging after benchmark5 passed https://github.com/neondatabase/neon/actions/runs/9482825569/job/26129422123?pr=8023
Will need to watch successful runs in CI for some time

@Bodobolero Bodobolero merged commit 9ba9f32 into main Jun 12, 2024
68 checks passed
@Bodobolero Bodobolero deleted the bodobolero/pagebench_activation branch June 12, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-benchmarks Indicates to the CI that benchmarks should be run for PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants