Skip to content

Commit

Permalink
Reactivate page bench test in CI after ignoring CopyFail error in pag…
Browse files Browse the repository at this point in the history
…eserver (#8023)

## Problem

Testcase page bench test_pageserver_max_throughput_getpage_at_latest_lsn
had been deactivated because it was flaky.

We now ignore copy fail error messages like in


https://github.com/neondatabase/neon/blob/270d3be507643f068120b52838c497f6c1b45b61/test_runner/regress/test_pageserver_getpage_throttle.py#L17-L20

and want to reactivate it to see it it is still flaky

## Summary of changes

- reactivate the test in CI
- ignore CopyFail error message during page bench test cases

## Checklist before requesting a review

- [ ] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Do we need to implement analytics? if so did you add the relevant
metrics to the dashboard?
- [ ] If this PR requires public announcement, mark it with
/release-notes label and add several sentences in this section.

## Checklist before merging

- [ ] Do not forget to reformat commit message to not include the above
checklist
  • Loading branch information
Bodobolero committed Jun 12, 2024
1 parent 3099e1a commit 9ba9f32
Showing 1 changed file with 8 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import json
import os
from pathlib import Path
from typing import Any, Dict, Tuple

Expand Down Expand Up @@ -35,10 +34,6 @@
@pytest.mark.timeout(
10000
) # TODO: this value is just "a really high number"; have this per instance type
@pytest.mark.skipif(
os.getenv("CI", "false") == "true",
reason="The test if flaky on CI: https://github.com/neondatabase/neon/issues/6724",
)
def test_pageserver_max_throughput_getpage_at_latest_lsn(
neon_env_builder: NeonEnvBuilder,
zenbenchmark: NeonBenchmarker,
Expand Down Expand Up @@ -91,6 +86,14 @@ def setup_wrapper(env: NeonEnv):
n_tenants,
setup_wrapper,
)

env.pageserver.allowed_errors.append(
# https://github.com/neondatabase/neon/issues/6925
# https://github.com/neondatabase/neon/issues/6390
# https://github.com/neondatabase/neon/issues/6724
r".*query handler for.*pagestream.*failed: unexpected message: CopyFail during COPY.*"
)

run_benchmark_max_throughput_latest_lsn(env, pg_bin, record, duration)


Expand Down

1 comment on commit 9ba9f32

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3298 tests run: 3146 passed, 1 failed, 151 skipped (full report)


Failures on Postgres 14

  • test_pageserver_max_throughput_getpage_at_latest_lsn[github-actions-selfhosted-10-6-30]: release
# Run all failed tests locally:
scripts/pytest -vv -n $(nproc) -k "test_pageserver_max_throughput_getpage_at_latest_lsn[release-pg14-github-actions-selfhosted-10-6-30]"
Flaky tests (1)

Postgres 14

  • test_storage_controller_smoke: release

Code coverage* (full report)

  • functions: 31.6% (6633 of 20989 functions)
  • lines: 48.6% (51498 of 106042 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9ba9f32 at 2024-06-12T15:34:25.780Z :recycle:

Please sign in to comment.