pagectl: key command for dumping what we know about the key #7890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koivunej
force-pushed
the
joonas/pagectl_key
branch
from
115cbae
to
dc9a884
Compare
3156 tests run: 3017 passed, 0 failed, 139 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
804d15b at 2024-05-31T18:27:45.566Z :recycle: |
arpad-m
reviewed
May 28, 2024
arpad-m
reviewed
May 28, 2024
jcsp
reviewed
May 30, 2024
it doesn't matter if the internals are borrowed or not for the implementation.
make it a type, so that it is explicit and formatting it is easier. add also query methods for relsize and slru dir kind, add a kind_query for "slru segment size".
example: ``` $ cargo run -qp pagectl -- rel-block-to-key --forknum 0 1663 16389 24615 1052204 000000067F00004005000060270000100E2C ```
also adds a ShardStripeSize::default
|
Oki the auxfilesv2 work is done. |
koivunej
force-pushed
the
joonas/pagectl_key
branch
from
b9148c9
to
152b76e
Compare
arpad-m
approved these changes
May 31, 2024
turns out not all of them were by value.
|
Well.. It seems not all of the current were by-value. What a mess, I'll merge this as it was when you approved it. It is possible I did some mistake, but I am very sure I tried to make only the ones I added as by-value. |
a-masterov
pushed a commit
that referenced
this pull request
Jun 3, 2024
What we know about the key via added `pagectl key $key` command:
- debug formatting
- shard placement when `--shard-count` is specified
- different boolean queries in `key.rs`
- aux files v2
Example:
```
$ cargo run -qp pagectl -- key 000000063F00004005000060270000100E2C
parsed from hex: 000000063F00004005000060270000100E2C:
Key { field1: 0, field2: 1599, field3: 16389, field4: 24615, field5: 0, field6: 1052204 }
rel_block: true
rel_vm_block: false
rel_fsm_block: false
slru_block: false
inherited: true
rel_size: false
slru_segment_size: false
recognized kind: None
```
arpad-m
added a commit
that referenced
this pull request
Jun 3, 2024
The keyspace utils like `is_rel_size_key` or `is_rel_fsm_block_key` and many others are free functions and have to be either imported separately or specified with the full path starting in `pageserver_api::key::`. This is less convenient than if these functions were just inherent impls. Follow-up of #7890 Fixes #6438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we know about the key via added
pagectl key $keycommand:--shard-countis specifiedkey.rsExample: