Move keyspace utils into Key impl
#6438
Labels
c/storage/pageserver
Component: storage: pageserver
Comments
5 tasks
|
I wonder if we'll win much by this. While working with the "keytool" in #7890 and looking at the auxfilesv2 work happening at the same time, I started thinking that: Before we make the relation metadata key change to be always on shard0 in finite number of layers, we should make this Then it will be easy to write the two different (v1, v2) mapping functions from this logical key to what is our less-logical key (u128). |
arpad-m
added a commit
that referenced
this issue
Jun 3, 2024
The keyspace utils like `is_rel_size_key` or `is_rel_fsm_block_key` and many others are free functions and have to be either imported separately or specified with the full path starting in `pageserver_api::key::`. This is less convenient than if these functions were just inherent impls. Follow-up of #7890 Fixes #6438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see those imports. I think if we move these functions to inherent impls on the
Keytype then we won't need as many of them, but I think it should be a separate PR.Originally posted by @arpad-m in #6406 (comment)
The text was updated successfully, but these errors were encountered: