Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lower gate guard drop logging threshold to 100ms #7862

Merged
merged 1 commit into from
May 24, 2024

Conversation

koivunej
Copy link
Member

We have some 1001ms cases, which do not yield gate guard context.

@koivunej koivunej requested a review from jcsp May 23, 2024 13:56
@koivunej koivunej changed the title chore: lower gate guard drop logging limit to 100ms chore: lower gate guard drop logging threshold to 100ms May 23, 2024
@koivunej koivunej marked this pull request as ready for review May 23, 2024 13:56
@koivunej koivunej enabled auto-merge (squash) May 23, 2024 13:56
Copy link

3108 tests run: 2981 passed, 0 failed, 127 skipped (full report)


Flaky tests (1)

Postgres 15

  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 31.4% (6449 of 20545 functions)
  • lines: 48.3% (49867 of 103282 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6e1f126 at 2024-05-23T14:51:23.754Z :recycle:

Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's keep an eye through next week on how much more chatty this becomes.

@koivunej koivunej merged commit a3f5b83 into main May 24, 2024
65 checks passed
@koivunej koivunej deleted the joonas/noisier_gate_closing branch May 24, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants