Skip to content

Commit

Permalink
chore: lower gate guard drop logging threshold to 100ms (#7862)
Browse files Browse the repository at this point in the history
We have some 1001ms cases, which do not yield gate guard context.
  • Loading branch information
koivunej authored May 24, 2024
1 parent 1455f5a commit a3f5b83
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion libs/utils/src/sync/gate.rs
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ impl Gate {
let started_at = std::time::Instant::now();
let mut do_close = std::pin::pin!(self.do_close());

let nag_after = Duration::from_secs(1);
// with 1s we rarely saw anything, let's try if we get more gate closing reasons with 100ms
let nag_after = Duration::from_millis(100);

let Err(_timeout) = tokio::time::timeout(nag_after, &mut do_close).await else {
return;
Expand Down

1 comment on commit a3f5b83

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3220 tests run: 3080 passed, 0 failed, 140 skipped (full report)


Flaky tests (2)

Postgres 16

  • test_pageserver_restarts_under_worload: release
  • test_vm_bit_clear_on_heap_lock: debug

Code coverage* (full report)

  • functions: 31.4% (6449 of 20536 functions)
  • lines: 48.3% (49935 of 103300 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
a3f5b83 at 2024-05-24T14:27:59.643Z :recycle:

Please sign in to comment.