Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy read ids from redis #7205

Merged
merged 19 commits into from
Apr 10, 2024
Merged

Proxy read ids from redis #7205

merged 19 commits into from
Apr 10, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Mar 21, 2024

Problem

Proxy doesn't know about existing endpoints.

Summary of changes

  • Added caching of all available endpoints.
  • On the high load, use it before going to cplane.
  • Report metrics for the outcome.
  • For rate limiter and credentials caching don't distinguish between -pooled and not

TODOs:

  • Make metrics more meaningful
  • Consider integrating it with the endpoint rate limiter
  • Test it together with cplane in preview

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova changed the base branch from main to proxy-aws-irsa-auth-for-elasticache March 21, 2024 23:56
@khanova khanova marked this pull request as ready for review March 21, 2024 23:57
@khanova khanova requested a review from a team as a code owner March 21, 2024 23:57
@khanova khanova requested review from conradludgate and removed request for a team March 21, 2024 23:57
Copy link

github-actions bot commented Mar 22, 2024

2748 tests run: 2630 passed, 0 failed, 118 skipped (full report)


Code coverage* (full report)

  • functions: 28.0% (6428 of 22933 functions)
  • lines: 46.7% (45108 of 96556 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
6b687a7 at 2024-04-09T17:57:55.376Z :recycle:

Base automatically changed from proxy-aws-irsa-auth-for-elasticache to main March 22, 2024 08:38
@khanova khanova merged commit dbac2d2 into main Apr 10, 2024
52 of 53 checks passed
@khanova khanova deleted the proxy-read-ids-from-redis branch April 10, 2024 00:40
khanova pushed a commit that referenced this pull request Apr 10, 2024
khanova added a commit that referenced this pull request Apr 10, 2024
This reverts commit dbac2d2.

## Problem

Proxy pods fails to install in k8s clusters, cplane release blocking.

## Summary of changes

Revert
khanova pushed a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants