Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Proxy read ids from redis (#7205)" #7350

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Revert "Proxy read ids from redis (#7205)" #7350

merged 2 commits into from
Apr 10, 2024

Conversation

khanova
Copy link
Contributor

@khanova khanova commented Apr 10, 2024

This reverts commit dbac2d2.

Problem

Proxy pods fails to install in k8s clusters, cplane release blocking.

Summary of changes

Revert

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@khanova khanova requested a review from a team as a code owner April 10, 2024 09:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

2754 tests run: 2636 passed, 0 failed, 118 skipped (full report)

Code coverage* (full report)

  • functions: 28.1% (6429 of 22865 functions)
  • lines: 46.8% (45140 of 96385 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
0a8086c at 2024-04-10T10:26:16.957Z :recycle:

@khanova khanova enabled auto-merge (squash) April 10, 2024 09:40
@khanova khanova merged commit 0bb04eb into main Apr 10, 2024
48 of 49 checks passed
@khanova khanova deleted the revert-proxy-read-ids-from-redis branch April 10, 2024 10:12
khanova pushed a commit that referenced this pull request Apr 10, 2024
Revert "Revert "Proxy read ids from redis (#7205)" (#7350)"
4ac8edd 
This reverts commit 0bb04eb.
@khanova khanova mentioned this pull request Apr 11, 2024
Merged
5 tasks
khanova added a commit that referenced this pull request Apr 11, 2024
@khanova
Read cplane events from regional redis (#7352)
40f15c3 
## Problem

Actually read redis events.

## Summary of changes

This is revert of #7350 +
fixes.
* Fixed events parsing
* Added timeout after connection failure
* Separated regional and global redis clients.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conradludgate conradludgate conradludgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanova @conradludgate