Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -Wmissing-prototypes for neon extension #7010

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Mar 4, 2024

Problem

ref #6188

Summary of changes

This pull request fixes -Wmissing-prototypes for the neon extension. Note that (1) the gcc version in CI and macOS is different, therefore some of the warning does not get reported when developing the neon extension locally. (2) the CI env variable COPT = -Werror does not get passed into the docker build process, therefore warnings are not treated as errors on CI.

There will be follow-up pull requests on solving other warnings. By the way, I did not figure out the default compile parameters in the CI env, and therefore this pull request is tested by manually adding -Wmissing-prototypes into the COPT.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@skyzh skyzh requested a review from a team as a code owner March 4, 2024 19:12
Copy link
Contributor

@save-buffer save-buffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Copy link

github-actions bot commented Mar 4, 2024

2484 tests run: 2361 passed, 0 failed, 123 skipped (full report)


Flaky tests (5)

Postgres 16

  • test_timeline_deletion_with_files_stuck_in_upload_queue: release
  • test_empty_branch_remote_storage_upload: debug

Postgres 15

  • test_tenant_delete_smoke: release

Postgres 14

Code coverage* (full report)

  • functions: 28.7% (6932 of 24172 functions)
  • lines: 47.2% (42514 of 90097 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
ce91539 at 2024-03-04T20:54:18.531Z :recycle:

Signed-off-by: Alex Chi Z <chi@neon.tech>
@skyzh
Copy link
Member Author

skyzh commented Mar 4, 2024

Hold this pull request until storage/compute release to avoid problems with changing C code unfamiliar to me (though I feel this modification is likely to be safe...). Will be included in next week's release.

@skyzh skyzh merged commit b036c32 into main Mar 5, 2024
53 checks passed
@skyzh skyzh deleted the skyzh/ext-neon-warning-1 branch March 5, 2024 15:03
skyzh added a commit that referenced this pull request Mar 11, 2024
proceeding #7010, close
#6188

## Summary of changes

This pull request (should) fix all warnings except
`-Wdeclaration-after-statement` in the neon extension compilation.

---------

Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants