-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Compute]: Warnings during the compilation #6188
Comments
It seems that these warnings cannot be reproduced on the dev server. So I guess it's specific to a compiler version when building our compute node image. |
And we are using gcc 10 https://packages.debian.org/bullseye/gcc in our build image |
I copied these warnings from CI |
Yep, it's specific to gcc 10 and some combination of compile flags. I'm extracting those info from CI and fixing them. Also |
Fixed |
## Problem ref #6188 ## Summary of changes This pull request fixes `-Wmissing-prototypes` for the neon extension. Note that (1) the gcc version in CI and macOS is different, therefore some of the warning does not get reported when developing the neon extension locally. (2) the CI env variable `COPT = -Werror` does not get passed into the docker build process, therefore warnings are not treated as errors on CI. https://github.com/neondatabase/neon/blob/e62baa97041e10ce45772b3724e24e679a650d69/.github/workflows/build_and_test.yml#L22 There will be follow-up pull requests on solving other warnings. By the way, I did not figure out the default compile parameters in the CI env, and therefore this pull request is tested by manually adding `-Wmissing-prototypes` into the `COPT`. Signed-off-by: Alex Chi Z <chi@neon.tech>
Newer versions of Ubuntu (GitHub Actions, local Docker on Mac) don't produce this. |
decided not to fix |
The text was updated successfully, but these errors were encountered: