Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use pinned version of ubuntu-latest runner #7256

Closed
bayandin opened this issue Mar 27, 2024 · 0 comments
Closed

CI: use pinned version of ubuntu-latest runner #7256

bayandin opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
a/ci Area: related to continuous integration m/good_first_issue Moment: when doing your first Neon contributions

Comments

@bayandin
Copy link
Member

bayandin commented Mar 27, 2024

We need to switch ubuntu-latest with ubuntu-22.04 (ref):

$ git grep ubuntu-latest -- .github
.github/workflows/actionlint.yml:    runs-on: ubuntu-latest
.github/workflows/approved-for-ci-run.yml:    runs-on: ubuntu-latest
.github/workflows/approved-for-ci-run.yml:    runs-on: ubuntu-latest
.github/workflows/approved-for-ci-run.yml:    runs-on: ubuntu-latest
.github/workflows/benchmarking.yml:    runs-on: ubuntu-latest
.github/workflows/build-build-tools-image.yml:    runs-on: ubuntu-latest
.github/workflows/build_and_test.yml:    runs-on: ubuntu-latest
.github/workflows/build_and_test.yml:    runs-on: ubuntu-latest
.github/workflows/check-build-tools-image.yml:    runs-on: ubuntu-latest
.github/workflows/check-permissions.yml:    runs-on: ubuntu-latest
.github/workflows/cleanup-caches-by-a-branch.yml:    runs-on: ubuntu-latest
.github/workflows/pg_clients.yml:    runs-on: [ ubuntu-latest ]
.github/workflows/pg_clients.yml:    # We use GitHub's action upload-artifact because `ubuntu-latest` doesn't have configured AWS CLI.
.github/workflows/pin-build-tools-image.yml:    runs-on: ubuntu-latest
.github/workflows/release-notify.yml:    runs-on: [ ubuntu-latest ]
.github/workflows/release.yml:    runs-on: ubuntu-latest
.github/workflows/release.yml:    runs-on: ubuntu-latest
.github/workflows/trigger-e2e-tests.yml:    runs-on: ubuntu-latest
.github/workflows/trigger-e2e-tests.yml:    runs-on: [ ubuntu-latest ]

Can we still pin the version? usually unpinned container versions result in something breaking mysteriously like 1yr later ;-)

Originally posted by @jcsp in #7229 (comment)

@bayandin bayandin added the a/ci Area: related to continuous integration label Mar 27, 2024
@bayandin bayandin added the m/good_first_issue Moment: when doing your first Neon contributions label May 28, 2024
a-masterov added a commit that referenced this issue May 30, 2024
## Problem
We use ubuntu-latest as a default OS for running jobs. It can cause
problems due to instability, so we should use the LTS version of Ubuntu.

## Summary of changes
The image ubuntu-latest was changed with ubuntu-22.04 in workflows.

## Checklist before requesting a review

- [x] I have performed a self-review of my code.
- [ ] If it is a core feature, I have added thorough tests.
- [ ] Do we need to implement analytics? if so did you add the relevant
metrics to the dashboard?
- [ ] If this PR requires public announcement, mark it with
/release-notes label and add several sentences in this section.

## Checklist before merging

- [ ] Do not forget to reformat commit message to not include the above
checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/ci Area: related to continuous integration m/good_first_issue Moment: when doing your first Neon contributions
Projects
None yet
Development

No branches or pull requests

2 participants