Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch ubuntu-latest with ubuntu-22.04 (#7256) #7901

Merged
merged 12 commits into from
May 30, 2024

Conversation

a-masterov
Copy link
Contributor

Problem

We use ubuntu-latest as a default OS for running jobs. It can cause problems due to instability, we should use lts version of Ubuntu.

Summary of changes

Runner ubuntu-latest was changed to ubuntu-22.04

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@a-masterov a-masterov requested a review from bayandin May 29, 2024 08:59
Copy link

github-actions bot commented May 29, 2024

3144 tests run: 3011 passed, 0 failed, 133 skipped (full report)


Flaky tests (1)

Postgres 14

  • test_download_remote_layers_api: release

Code coverage* (full report)

  • functions: 31.4% (6490 of 20663 functions)
  • lines: 48.4% (50211 of 103724 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
1f8d465 at 2024-05-29T15:02:58.637Z :recycle:

@bayandin bayandin changed the title We need to switch ubuntu-latest with ubuntu-22.04 (#7256) CI: switch ubuntu-latest with ubuntu-22.04 (#7256) May 29, 2024
Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of notes:

  • I wonder if it's possible to disallow usage of ubuntu-latest (by actionlint, for example)?
  • Let's changes runs-on: [ ubuntu-22.04 ] to runs-on: ubuntu-22.04 for consistensy

@bayandin bayandin self-requested a review May 29, 2024 12:01
@a-masterov a-masterov merged commit b0a954b into main May 30, 2024
70 checks passed
@a-masterov a-masterov deleted the amasterov-ubuntu-lts branch May 30, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants