This repository has been archived by the owner on May 18, 2023. It is now read-only.
Fixes tests on windows while preserving intent of tests. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I can confirm the test now all pass on Windows and Mac 👍 |
mikegwhit
added a commit
that referenced
this pull request
Oct 12, 2020
* 1.3.0 (#83) * Changes to the contribution guide for the additional steps in the release process (#85) * Small patch fixing windows (#94) * Adds tsc fix for auto-delete-bucket. Adds eslint ignore folders. Adds one-line windows fix. * Lints. Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * Feature/constructor types 89 (#90) * feat(types): fix type on cicd #89 * feat(types): fix type route53 manager #89 * feat(types): fix type custom resources #89 * feat(types): fix app.ts #89 * feat(types): fix types on cdk root #89 * Feature/types fix 90 (#93) * feat(types): fix type on cicd #89 * feat(types): fix type route53 manager #89 * feat(types): fix type custom resources #89 * feat(types): fix app.ts #89 * feat(types): fix types on cdk root #89 * feat(types): finalize typing * Fixes tests on windows while preserving intent of tests. (#97) * Fixes tests on windows while preserving intent of tests. * lints Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * Bump node-fetch from 2.6.0 to 2.6.1 (#98) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix/local mira (#96) * Adds tsc fix for auto-delete-bucket. Adds eslint ignore folders. Adds one-line windows fix. * Lints. * Adds --preserve-symlinks and a patch to run Mira from a local link context. * Lint * Adds the link script. Patches simple fix for the bootstrap file. * Adds link to ignored files. * Lints the link file. * lints * lints and adds the bin files. * Adds documentation. * Adds implementation details for Mira * Adds try catch blocks around the symlinking steps. Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * Fix: set removal policy of CICD KMS key to destroy (#106) * Set removal policy of CICD KMS key to destroy * add note * Fix/calleridentity fallback (#108) * Handle iam.getUser error and fallback to sts * Add test to fallback flow * Adds the --s3-only quick deploy feature. (#111) * Adds the --s3-only quick deploy feature. * Adds docs. * Adds in better messaging for the quick deploy * lints and undos linter rule * Readme updates * Readme updates Co-authored-by: Mike Whit <mail+git@mikewhit.com> * Docs refactor (#115) * Docs refactor * Addressed feedback from Mike W * feat(deploy): add --require-approval arg support, return error on fail (#117) * fix domain support (#110) * fix domain support * add domain to available commands * Update CDK version to 1.67.0 (#120) * Feature/cfn sdk lookups (#112) * Adds the --s3-only quick deploy feature. * Adds docs. * Adds in better messaging for the quick deploy * lints and undos linter rule * Readme updates * Readme updates * Adds CloudFormation SDK hookup. Uses this to create info message when running quick deploy. * addresses pr feedback Co-authored-by: Mike Whit <mail+git@mikewhit.com> Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * 1.4.0 (#121) * 1.3.0 (#83) (#84) (#123) Co-authored-by: Mark Ireland <mark.ireland@nearform.com> Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> Co-authored-by: Mark Ireland <mark.ireland@nearform.com> Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> Co-authored-by: Davide Fiorello <davide@codeflyer.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Balazs <frikille@gmail.com> Co-authored-by: Mike Whit <mail+git@mikewhit.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #95