-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this is checked to be working for everyone, please add a doc file that explains how and when to use it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting this error now (wasn't in a previous version of this PR):
marki@Marks-MBP-2:~/mira/mira (git fix/rebuild-dist) - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - [10:23:22]
$ node scripts/link.js ../test8-s3wh/
Looks like Mira has already been installed in mira-sample-s3-webhosting
Backing up old mira dependency to /Users/marki/mira/test8-s3wh/mira.old
mira.old folder already exists, deleting.
internal/fs/utils.js:269
throw err;
^
Error: EEXIST: file already exists, symlink '/Users/marki/mira/mira/scripts/bin/mira' -> '/Users/marki/mira/test8-s3wh/node_modules/.bin/mira'
at Object.symlinkSync (fs.js:1095:3)
at /Users/marki/mira/mira/scripts/link.js:24:12
at Array.forEach ()
at createMiraBootstrap (/Users/marki/mira/mira/scripts/link.js:23:40)
at Object. (/Users/marki/mira/mira/scripts/link.js:140:5)
at Module._compile (internal/modules/cjs/loader.js:1137:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
at Module.load (internal/modules/cjs/loader.js:985:32)
at Function.Module._load (internal/modules/cjs/loader.js:878:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) {
errno: -17,
syscall: 'symlink',
code: 'EEXIST',
path: '/Users/marki/mira/mira/scripts/bin/mira',
dest: '/Users/marki/mira/test8-s3wh/node_modules/.bin/mira'
}
Would the branch you are on have something to do with the symlink issue? On the |
Patched @irelandm @nigelhanlon |
This works for me. I am happy to approve but will hold off until Mark has a chance to test as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works for me now.
At some point we should change those NOOP comments to log messages (we'd like to know if they are ever reached), but good to go
* 1.3.0 (#83) * Changes to the contribution guide for the additional steps in the release process (#85) * Small patch fixing windows (#94) * Adds tsc fix for auto-delete-bucket. Adds eslint ignore folders. Adds one-line windows fix. * Lints. Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * Feature/constructor types 89 (#90) * feat(types): fix type on cicd #89 * feat(types): fix type route53 manager #89 * feat(types): fix type custom resources #89 * feat(types): fix app.ts #89 * feat(types): fix types on cdk root #89 * Feature/types fix 90 (#93) * feat(types): fix type on cicd #89 * feat(types): fix type route53 manager #89 * feat(types): fix type custom resources #89 * feat(types): fix app.ts #89 * feat(types): fix types on cdk root #89 * feat(types): finalize typing * Fixes tests on windows while preserving intent of tests. (#97) * Fixes tests on windows while preserving intent of tests. * lints Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * Bump node-fetch from 2.6.0 to 2.6.1 (#98) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix/local mira (#96) * Adds tsc fix for auto-delete-bucket. Adds eslint ignore folders. Adds one-line windows fix. * Lints. * Adds --preserve-symlinks and a patch to run Mira from a local link context. * Lint * Adds the link script. Patches simple fix for the bootstrap file. * Adds link to ignored files. * Lints the link file. * lints * lints and adds the bin files. * Adds documentation. * Adds implementation details for Mira * Adds try catch blocks around the symlinking steps. Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * Fix: set removal policy of CICD KMS key to destroy (#106) * Set removal policy of CICD KMS key to destroy * add note * Fix/calleridentity fallback (#108) * Handle iam.getUser error and fallback to sts * Add test to fallback flow * Adds the --s3-only quick deploy feature. (#111) * Adds the --s3-only quick deploy feature. * Adds docs. * Adds in better messaging for the quick deploy * lints and undos linter rule * Readme updates * Readme updates Co-authored-by: Mike Whit <mail+git@mikewhit.com> * Docs refactor (#115) * Docs refactor * Addressed feedback from Mike W * feat(deploy): add --require-approval arg support, return error on fail (#117) * fix domain support (#110) * fix domain support * add domain to available commands * Update CDK version to 1.67.0 (#120) * Feature/cfn sdk lookups (#112) * Adds the --s3-only quick deploy feature. * Adds docs. * Adds in better messaging for the quick deploy * lints and undos linter rule * Readme updates * Readme updates * Adds CloudFormation SDK hookup. Uses this to create info message when running quick deploy. * addresses pr feedback Co-authored-by: Mike Whit <mail+git@mikewhit.com> Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> * 1.4.0 (#121) * 1.3.0 (#83) (#84) (#123) Co-authored-by: Mark Ireland <mark.ireland@nearform.com> Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> Co-authored-by: Mark Ireland <mark.ireland@nearform.com> Co-authored-by: Mike Whit <mikegwhit@users.noreply.github.com> Co-authored-by: Davide Fiorello <davide@codeflyer.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Peter Balazs <frikille@gmail.com> Co-authored-by: Mike Whit <mail+git@mikewhit.com>
References #88
Solves by way of utilizing
--preserve-symlinks
and then modifiesgetCDKArgs
to supply a file that is not symlinked. This file is created programmatically (which may introduce conflicts later on should a package calledmira-bootstrap
ever be created). This file is a one-line code file requiring the intended Mira target file for all CDK applications:dist/src/cdk/app.js
This functionality of
--preserve-symlinks
seems like it was introduced in Node v6. It's unknown if a later version of Node or CDK will break this functionality.