Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed JetStream ACK custom serialization #255

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Fixed JetStream ACK custom serialization #255

merged 3 commits into from
Nov 28, 2023

Commits on Nov 28, 2023

  1. Fixed JetStream ACK custom serialization 

    When a custom serializer used JetStream msg ACKs are still being serialized
using the custom serializer which is resulting in +ACK being sent to the
server with a distorted format. Now we just used the NATS default serializer
on message ACKs to format the +ACK/NAK/etc. payload correctly.

ConsumerFetchTest.cs was also passing for the wrong reasons, which is also
fixed. Plus minor format issue fixed.
    @mtmk
    mtmk committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d0ebfda View commit details
    Browse the repository at this point in the history

  2. Fixed consume ack test

    @mtmk
    mtmk committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    51ee320 View commit details
    Browse the repository at this point in the history

  3. Test flap tuning

    @mtmk
    mtmk committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c9309bf View commit details
    Browse the repository at this point in the history