Fixed JetStream ACK custom serialization #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a custom serializer used JetStream msg ACKs are still being serialized using the custom serializer which is resulting in +ACK being sent to the server with a distorted format. Now we just used the NATS default serializer on message ACKs to format the +ACK/NAK/etc. payload correctly. ConsumerFetchTest.cs was also passing for the wrong reasons, which is also fixed. Plus minor format issue fixed.
|
usual test flappers left. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a custom serializer used JetStream msg ACKs are still being serialized using the custom serializer which is resulting in +ACK being sent to the server with a distorted format. Now we just used the NATS default serializer on message ACKs to format the +ACK/NAK/etc. payload correctly.
ConsumerFetchTest.cs was also passing for the wrong reasons, which is also fixed. Plus minor format issue fixed.