Use UT assert for OSAL unit tests #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the "unit-tests" (extended/functional tests) for OSAL to use the UT assert library for test case reporting and platform support. Reduce or eliminate the use of macros for platform abstraction wherever possible. This removes most platform-specific logic from the test cases, leaving that to the OSAL/BSP abstraction.
skliper
reviewed
Dec 17, 2019
skliper
approved these changes
Dec 17, 2019
skliper
added
the
CCB:Approved
|
CCB 20191218 - Reviewed and approved for IC |
This was referenced Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #313
Refactor the "unit-tests" (extended/functional tests) for OSAL to use the UT assert library for test case reporting and platform support.
Reduce or eliminate the use of macros for platform abstraction wherever possible. This removes most platform-specific logic from the test cases, leaving that to the OSAL/BSP abstraction.
Testing performed
Build unit tests for all three supported test platforms and confirm operation (POSIX, VxWorks, RTEMS).
Expected behavior changes
Tests were previously only being built/executed on POSIX. Now the tests are built on all OSAL platforms, using the UT assert library.
Output logfiles are in provided by UT assert and are therefore now in the same UT assert style. This test set no longer has a different set of output files.
System(s) tested on:
Additional context
This should be pulled in parallel with #317 to ensure that the POSIX platform continues to pass all tests. Note that the relevant tests (FPU, interrupt) were being skipped on POSIX., but with this change all tests are executed on all platforms.
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted