Exception/Interrupt API updates #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure the FPU functions that are actually not implemented in RTEMS/POSIX all return OS_ERR_NOT_IMPLEMENTED, not OS_SUCCESS. - The RTEMS IntEnable/Disable API should not be a duplicate of the IntLock/Unlock API, as the semantics are slightly different. The Enable/Disable API should return OS_ERR_NOT_IMPLEMENTED. - The OS_FPUExcGetMask API should confirm that the output buffer is not NULL.
skliper
approved these changes
Dec 17, 2019
skliper
added
the
CCB:Approved
|
CCB 20191218 - Reviewed and approved for IC |
skliper
added a commit
that referenced
this pull request
Dec 31, 2019
Fix #297 Reviewed and approved at 2019-12-18 CCB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #316
The Enable/Disable API should return OS_ERR_NOT_IMPLEMENTED.
Testing performed
Sanity check on basic CFE operation on native/simulation build - no changes to FSW behavior.
Modified APIs are exercised in the OSAL unit tests. Unit tests executed on RTEMS, POSIX (native), and VxWorks in conjunction with changeset for #313.
Expected behavior changes
No change to FSW.
Unit tests related to these particular API calls now all PASS or are skipped appropriately for the ones that are actually not implemented.
System(s) tested on:
Contributor Info
Joseph Hickey, Vantage Systems, Inc.
Community contributors
You must attach a signed CLA (required for acceptance) or reference one already submitted