Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cppcheck for os dir. #308

Closed
avan989 opened this issue Dec 12, 2019 · 0 comments · Fixed by #334
Closed

Cppcheck for os dir. #308

avan989 opened this issue Dec 12, 2019 · 0 comments · Fixed by #334
Labels
enhancement
Milestone
Bootes

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 12, 2019

Is your feature request related to a problem? Please describe.
From issue #303

[osal/src/os/portable/os-impl-posix-dl.c:54]: (style) struct member 'OS_impl_module_internal_record_t::dl_handle' is never used.
[osal/src/os/posix/os-posix.h:110] -> [osal/src/os/posix/osapi.c:737]: (style, inconclusive) Function 'OS_Posix_InternalTaskCreate_Impl' argument 1 names different: declaration 'thr' definition 'pthr'.
[osal/src/os/posix/os-posix.h:110] -> [osal/src/os/posix/osapi.c:737]: (style, inconclusive) Function 'OS_Posix_InternalTaskCreate_Impl' argument 4 names different: declaration 'Entry' definition 'entry'.
[osal/src/os/posix/osapi.c:163] -> [osal/src/os/posix/osapi.c:2264]: (style, inconclusive) Function 'OS_CompAbsDelayTime' argument 1 names different: declaration 'milli_second' definition 'msecs'.
[osal/src/os/rtems/osloader.c:43]: (style) struct member 'OS_impl_module_internal_record_t::dl_handle' is never used.

Requester Info
Anh Van, NASA Goddard
skliper pushed a commit that referenced this issue Dec 30, 2019
@skliper
issue #308, Resolve cpp warning in os dir.
ca742b0
skliper added a commit that referenced this issue Dec 30, 2019
@skliper
CCB 20191218: Merge #296 #299 #306 #310 #311 #315 #317 #318 #322 #324
9e3027f 
Fix #295, #298, #305, #307, #308,
    #313, #314, #316, #321, #323
Reviewed and approved at 2019-12-18 CCB
@skliper skliper mentioned this issue Dec 31, 2019
Merged
@skliper skliper added this to the 5.1.0 milestone Jan 2, 2020
@skliper skliper mentioned this issue Jan 2, 2020
Closed
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@CDKnightNASA
fix for nasa#308 - improved create pipe error reporting with eid and …
7d13f76 
…unit test changes
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#452 from CDKnightNASA/fix-308-createpipe_msgs
f26f323 
Fix nasa#308, Improve SB create pipe error reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Bootes
Development

Successfully merging a pull request may close this issue.

Integration Candidate 20191230 nasa/osal
2 participants
@avan989 @skliper