Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --rpcconfig option and fix wallet config bug #3069

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add --rpcconfig option and fix wallet config bug #3069

merged 1 commit into from
Jan 26, 2021

Conversation

cryptocode
Copy link
Contributor

Closes #3067

  • Adds a new --rpcconfig option to nano_node and nano_wallet
  • Fixes a bug on develop where the wallet doesn't work with the --config option. Changing from string to config_key_value_pair in the boost option fixed the issue.
  • Removed a block of dead code

Current override unit test for toml should cover the new code.

@cryptocode cryptocode self-assigned this Dec 10, 2020
@wezrule wezrule self-requested a review December 10, 2020 21:16
@wezrule wezrule added this to the V22.0 milestone Dec 10, 2020
@wezrule wezrule added bug enhancement documentation This item indicates the need for or supplies updated or expanded documentation labels Dec 14, 2020
@zhyatt zhyatt requested a review from argakiig January 26, 2021 16:07
@argakiig argakiig merged commit 3d5f7e5 into nanocurrency:develop Jan 26, 2021
@zhyatt zhyatt mentioned this pull request Feb 9, 2021
Closed
20 tasks
@zhyatt zhyatt mentioned this pull request May 12, 2021
Closed
@cryptocode cryptocode mentioned this pull request Jan 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wezrule wezrule wezrule approved these changes

@argakiig argakiig argakiig approved these changes

Assignees

@cryptocode cryptocode

Labels
bug documentation This item indicates the need for or supplies updated or expanded documentation enhancement
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.

Suggestion: add command line options for RPC Configs
3 participants
@cryptocode @wezrule @argakiig