Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(masked-errors): Use the custom error formatter for the errors thrown when building the context and the subscription #1456

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jul 27, 2022

See the changeset.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2022

🦋 Changeset detected

Latest commit: 4a0ee4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@envelop/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
envelop ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 10:35AM (UTC)

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 27, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/core@2.4.1-alpha-ffbace6f.0
@envelop/apollo-datasources@1.1.1-alpha-ffbace6f.0
@envelop/apollo-federation@2.4.1-alpha-ffbace6f.0
@envelop/apollo-server-errors@3.4.1-alpha-ffbace6f.0
@envelop/apollo-tracing@3.4.1-alpha-ffbace6f.0
@envelop/auth0@3.4.1-alpha-ffbace6f.0
@envelop/dataloader@3.4.1-alpha-ffbace6f.0
@envelop/depth-limit@1.6.1-alpha-ffbace6f.0
@envelop/disable-introspection@3.4.1-alpha-ffbace6f.0
@envelop/execute-subscription-event@2.4.1-alpha-ffbace6f.0
@envelop/extended-validation@1.7.1-alpha-ffbace6f.0
@envelop/filter-operation-type@3.4.1-alpha-ffbace6f.0
@envelop/fragment-arguments@3.4.1-alpha-ffbace6f.0
@envelop/generic-auth@4.3.1-alpha-ffbace6f.0
@envelop/graphql-jit@4.4.1-alpha-ffbace6f.0
@envelop/graphql-middleware@3.4.1-alpha-ffbace6f.0
@envelop/graphql-modules@3.4.1-alpha-ffbace6f.0
@envelop/live-query@3.4.1-alpha-ffbace6f.0
@envelop/newrelic@4.1.1-alpha-ffbace6f.0
@envelop/opentelemetry@3.4.1-alpha-ffbace6f.0
@envelop/operation-field-permissions@3.4.1-alpha-ffbace6f.0
@envelop/parser-cache@4.5.1-alpha-ffbace6f.0
@envelop/persisted-operations@4.4.1-alpha-ffbace6f.0
@envelop/preload-assets@3.4.1-alpha-ffbace6f.0
@envelop/prometheus@6.4.1-alpha-ffbace6f.0
@envelop/rate-limiter@3.4.1-alpha-ffbace6f.0
@envelop/resource-limitations@2.4.1-alpha-ffbace6f.0
@envelop/response-cache@3.0.1-alpha-ffbace6f.0
@envelop/response-cache-redis@1.0.1-alpha-ffbace6f.0
@envelop/sentry@3.6.1-alpha-ffbace6f.0
@envelop/statsd@2.4.1-alpha-ffbace6f.0
@envelop/validation-cache@4.5.1-alpha-ffbace6f.0
@envelop/testing@4.4.1-alpha-ffbace6f.0

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jul 27, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 514444     ✗ 0     
     data_received......................................: 2.0 GB  13 MB/s
     data_sent..........................................: 112 MB  746 kB/s
     envelop_init.......................................: avg=704ns    min=199ns    med=400ns    max=635.73µs p(90)=1.1µs    p(95)=2.39µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=465ns    min=199ns    med=400ns    max=219.11µs p(90)=699ns    p(95)=899ns   
     ✓ { mode:envelop-just-cache }......................: avg=467ns    min=199ns    med=400ns    max=635.73µs p(90)=599ns    p(95)=699ns   
     ✓ { mode:graphql-js }..............................: avg=703ns    min=199ns    med=399ns    max=113µs    p(90)=2.7µs    p(95)=3µs     
     ✓ { mode:prom-tracing }............................: avg=3.18µs   min=1.59µs   med=2.29µs   max=329.91µs p(90)=9µs      p(95)=9.7µs   
     envelop_total......................................: avg=237.71µs min=0s       med=24.4µs   max=18.05ms  p(90)=543.82µs p(95)=1.71ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=24.83µs  min=17.7µs   med=22.69µs  max=10.29ms  p(90)=31.3µs   p(95)=34µs    
     ✓ { mode:envelop-just-cache }......................: avg=219.96µs min=181.6µs  med=211.7µs  max=8.22ms   p(90)=231.57µs p(95)=244.11µs
     ✓ { mode:graphql-js }..............................: avg=587.65µs min=472.92µs med=534.52µs max=18.05ms  p(90)=586.42µs p(95)=634.43µs
     ✓ { mode:prom-tracing }............................: avg=1.9ms    min=1.56ms   med=1.75ms   max=16.76ms  p(90)=1.94ms   p(95)=3.11ms  
     event_loop_lag.....................................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-cache-jit }.......................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:envelop-just-cache }......................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:graphql-js }..............................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     ✓ { mode:prom-tracing }............................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     graphql_context....................................: avg=4.32µs   min=1.89µs   med=3.19µs   max=4.84ms   p(90)=7.2µs    p(95)=8.2µs   
     ✓ { mode:envelop-cache-jit }.......................: avg=3.25µs   min=1.89µs   med=2.89µs   max=4.84ms   p(90)=4.19µs   p(95)=4.9µs   
     ✓ { mode:envelop-just-cache }......................: avg=3.38µs   min=2.29µs   med=3.09µs   max=849.04µs p(90)=4.1µs    p(95)=4.69µs  
     ✓ { mode:graphql-js }..............................: avg=6.91µs   min=4.2µs    med=5.6µs    max=3.89ms   p(90)=9.69µs   p(95)=10.9µs  
     ✓ { mode:prom-tracing }............................: avg=8.56µs   min=6.7µs    med=8µs      max=334.31µs p(90)=9.2µs    p(95)=11.1µs  
     graphql_execute....................................: avg=243.94µs min=9.5µs    med=193.2µs  max=16.66ms  p(90)=227.31µs p(95)=1.66ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=12.55µs  min=9.5µs    med=11.4µs   max=8.49ms   p(90)=14.7µs   p(95)=16.1µs  
     ✓ { mode:envelop-just-cache }......................: avg=207.34µs min=171.7µs  med=200.1µs  max=8.21ms   p(90)=215.11µs p(95)=227.11µs
     ✓ { mode:graphql-js }..............................: avg=226.27µs min=178.8µs  med=203.8µs  max=13.64ms  p(90)=220.31µs p(95)=232.21µs
     ✓ { mode:prom-tracing }............................: avg=1.82ms   min=1.49ms   med=1.67ms   max=16.66ms  p(90)=1.83ms   p(95)=3.03ms  
     graphql_parse......................................: avg=11.8µs   min=3.99µs   med=5.89µs   max=7.07ms   p(90)=19.1µs   p(95)=56.6µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=6.2µs    min=3.99µs   med=5.69µs   max=2.09ms   p(90)=8.29µs   p(95)=9.39µs  
     ✓ { mode:envelop-just-cache }......................: avg=6.25µs   min=4.19µs   med=5.5µs    max=1.88ms   p(90)=7.2µs    p(95)=9.79µs  
     ✓ { mode:graphql-js }..............................: avg=15.61µs  min=9.9µs    med=12.3µs   max=7.07ms   p(90)=20µs     p(95)=22.6µs  
     ✓ { mode:prom-tracing }............................: avg=60.58µs  min=49.3µs   med=58µs     max=2.1ms    p(90)=67.6µs   p(95)=73.8µs  
     graphql_validate...................................: avg=61.73µs  min=1.6µs    med=2.3µs    max=15.55ms  p(90)=309.11µs p(95)=318.61µs
     ✓ { mode:envelop-cache-jit }.......................: avg=2.35µs   min=1.6µs    med=2.19µs   max=4.02ms   p(90)=2.6µs    p(95)=2.7µs   
     ✓ { mode:envelop-just-cache }......................: avg=2.5µs    min=1.79µs   med=2.29µs   max=1.36ms   p(90)=2.6µs    p(95)=2.79µs  
     ✓ { mode:graphql-js }..............................: avg=338.14µs min=268.01µs med=310.61µs max=15.55ms  p(90)=339.37µs p(95)=363.71µs
     ✓ { mode:prom-tracing }............................: avg=7.34µs   min=5.19µs   med=6.4µs    max=1.8ms    p(90)=8.1µs    p(95)=11.8µs  
     http_req_blocked...................................: avg=3.09µs   min=700ns    med=1.5µs    max=9.22ms   p(90)=2.29µs   p(95)=2.9µs   
     http_req_connecting................................: avg=403ns    min=0s       med=0s       max=5.27ms   p(90)=0s       p(95)=0s      
     http_req_duration..................................: avg=5.37ms   min=237.21µs med=3.45ms   max=97.27ms  p(90)=11.3ms   p(95)=18.41ms 
       { expected_response:true }.......................: avg=5.37ms   min=237.21µs med=3.45ms   max=97.27ms  p(90)=11.3ms   p(95)=18.41ms 
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=4.06ms   min=469.32µs med=3.22ms   max=46.23ms  p(90)=6.64ms   p(95)=7.73ms  
     ✓ { mode:envelop-cache-jit }.......................: avg=3.14ms   min=237.21µs med=2.39ms   max=30.45ms  p(90)=6.49ms   p(95)=10.44ms 
     ✓ { mode:envelop-just-cache }......................: avg=4.48ms   min=441.92µs med=3.51ms   max=38.13ms  p(90)=7.4ms    p(95)=9.24ms  
     ✓ { mode:graphql-js }..............................: avg=8.53ms   min=849.44µs med=6.76ms   max=77.46ms  p(90)=13.87ms  p(95)=15.71ms 
     ✓ { mode:prom-tracing }............................: avg=21.34ms  min=2.57ms   med=19.01ms  max=97.27ms  p(90)=36.9ms   p(95)=38.43ms 
     http_req_failed....................................: 0.00%   ✓ 0          ✗ 257222
     http_req_receiving.................................: avg=58.43µs  min=14.7µs   med=25.9µs   max=31.16ms  p(90)=40.2µs   p(95)=46.6µs  
     http_req_sending...................................: avg=44.81µs  min=5.4µs    med=9.2µs    max=31.5ms   p(90)=18.7µs   p(95)=28.8µs  
     http_req_tls_handshaking...........................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...................................: avg=5.26ms   min=192.6µs  med=3.4ms    max=97.18ms  p(90)=10.96ms  p(95)=18.27ms 
     http_reqs..........................................: 257222  1714.67183/s
     iteration_duration.................................: avg=5.82ms   min=513.92µs med=3.81ms   max=97.69ms  p(90)=12.13ms  p(95)=18.92ms 
     iterations.........................................: 257222  1714.67183/s
     vus................................................: 10      min=10       max=20  
     vus_max............................................: 20      min=20       max=20  

@n1ru4l
Copy link
Owner

n1ru4l commented Jul 28, 2022

@ardatan Tests still seems to be failing :(

@ardatan
Copy link
Collaborator Author

ardatan commented Jul 28, 2022

@n1ru4l Yes let me check :(

@ardatan
Copy link
Collaborator Author

ardatan commented Jul 28, 2022

@n1ru4l Ok it seems I forgot to push my last changes :D

…own when building the context and the subscription
@n1ru4l n1ru4l merged commit 787d28a into main Jul 28, 2022
@n1ru4l n1ru4l deleted the fix-masked-errors branch July 28, 2022 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants