Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GraphQLYogaError #1473

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Drop GraphQLYogaError #1473

merged 6 commits into from
Jul 29, 2022

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Jul 26, 2022

See the changeset
Closes #1327

https://github.com/n1ru4l/envelop/blob/main/packages/core/src/plugins/use-masked-errors.ts#L17
Without breaking Envelop, we need a custom formatter in order to respect all GraphQLErrors not only `EnvelopError
@n1ru4l Let me know if this is the right way to do that.

@ardatan ardatan requested a review from n1ru4l July 26, 2022 11:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: d4f034e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
graphql-yoga Major
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/persisted-operations Major
@graphql-yoga/plugin-response-cache Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
azure-function Patch
cloudflare-advanced Patch
cloudflare Patch
defer-stream-example Patch
error-masking-example Patch
express-example Patch
fastify-modules-example Patch
fastify-example Patch
file-upload-nextjs-pothos Patch
file-upload-nexus Patch
file-upload Patch
example-generic-auth Patch
graphql-config-example Patch
graphql-ws Patch
hackernews Patch
hello-world Patch
issue-template Patch
koa-example Patch
example-live-query Patch
nextjs-auth Patch
nextjs Patch
node-esm Patch
example-redis-pub-sub Patch
service-worker Patch
subscriptions-example Patch
sveltekit Patch
hello-world-benchmark Patch
graphql-lambda Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan changed the base branch from master to v3 July 26, 2022 11:27
@ardatan ardatan changed the title Drop graphql yoga error Drop GraphQLYogaError Jul 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 185784      ✗ 0    
     data_received..................: 25 MB   824 kB/s
     data_sent......................: 11 MB   356 kB/s
     http_req_blocked...............: avg=1.23µs   min=800ns   med=1.1µs    max=531.7µs p(90)=1.5µs   p(95)=1.8µs  
     http_req_connecting............: avg=1ns      min=0s      med=0s       max=117.1µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=246.89µs min=169µs   med=224.35µs max=17.39ms p(90)=288.5µs p(95)=313.8µs
       { expected_response:true }...: avg=246.89µs min=169µs   med=224.35µs max=17.39ms p(90)=288.5µs p(95)=313.8µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 92892
     http_req_receiving.............: avg=18.93µs  min=11µs    med=17.8µs   max=4.72ms  p(90)=23.1µs  p(95)=25.8µs 
     http_req_sending...............: avg=7.22µs   min=4.1µs   med=5.1µs    max=1.82ms  p(90)=10.6µs  p(95)=11.4µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=220.74µs min=147.9µs med=200.3µs  max=17.26ms p(90)=255.7µs p(95)=281.2µs
     http_reqs......................: 92892   3096.244489/s
     iteration_duration.............: avg=316.76µs min=223.2µs med=290.2µs  max=17.88ms p(90)=370.5µs p(95)=402.6µs
     iterations.....................: 92892   3096.244489/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legit 👌

@n1ru4l n1ru4l merged commit c4b3a9c into v3 Jul 29, 2022
@n1ru4l n1ru4l deleted the drop-graphql-yoga-error branch July 29, 2022 10:53
@ardatan ardatan self-assigned this Aug 2, 2022
@theguild-bot theguild-bot mentioned this pull request Aug 9, 2022
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants